purge: amount_goal in Grants #6457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6457 +/- ##
==========================================
+ Coverage 27.18% 27.20% +0.02%
==========================================
Files 289 289
Lines 26464 26458 -6
Branches 3923 3922 -1
==========================================
+ Hits 7194 7198 +4
+ Misses 19003 18993 -10
Partials 267 267
Continue to review full report at Codecov.
|
danlipert
reviewed
Apr 21, 2020
| @@ -22,7 +22,6 @@ def record_grant_activity_helper(activity_type, grant, profile, date): | |||
| metadata = { | |||
| 'id': grant.id, | |||
| 'value_in_token': '{0:.2f}'.format(grant.amount_received), | |||
| 'amount_goal': '{0:.2f}'.format(grant.amount_goal), | |||
There was a problem hiding this comment.
This migration is cursed, would love to get rid of it somehow
danlipert
approved these changes
Apr 21, 2020
octavioamu
approved these changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Flows Tested
TO-CHECK @danlipert + @octavioamu :
Had to update
0034_data_for_old_grants.pywhich was a custom migration created to populate grants activity when the feature was introduced