Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show active andd canceled grant subscriptions in profile #6455

Merged
merged 6 commits into from
Apr 29, 2020

Conversation

vporton
Copy link
Contributor

@vporton vporton commented Apr 17, 2020

Description

Now subscriptions are displayed in profile.

I did layout somehow imperfectly. The task was to reuse existing styles, but that's impossible since:

  1. I added amount / period column.
  2. I removed the date column since the dates in the DB (last_contribution_date and next_contribution_date) are erroneous (point somewhere in 1990).

Thus I was forced to change the layout a little. I did it as I can, but I am not a designer.

Refers/Fixes

#6448

Testing

It is an UI task, testing is done manually. My layout is responsive.

@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #6455 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6455      +/-   ##
==========================================
+ Coverage   27.06%   27.08%   +0.02%     
==========================================
  Files         291      291              
  Lines       26688    26688              
  Branches     3950     3950              
==========================================
+ Hits         7223     7229       +6     
+ Misses      19198    19192       -6     
  Partials      267      267              
Impacted Files Coverage Δ
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c844584...95c4e56. Read the comment docs.

@owocki
Copy link
Contributor

owocki commented Apr 17, 2020

code looks sane. do u have a screenshot we can checkout?

adding u to the PR review board that the engineers manage

@vporton
Copy link
Contributor Author

vporton commented Apr 17, 2020

Screenshot from 2020-04-17 19-37-43
The cost of subscription is overstriken to indicate that the subscription was canceled.

@thelostone-mc thelostone-mc merged commit 18a0b22 into gitcoinco:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants