Hackathon Townsquare - General Cleanup and Project Panel Updates #6439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… one of the items
- register button pushes users to onboarding - only prizes and projects are available to non registered users - cleanup of stale code/review tweaks
…ate filter to prevent long running paragraphs
Codecov Report
@@ Coverage Diff @@
## master #6439 +/- ##
==========================================
+ Coverage 27.18% 27.85% +0.67%
==========================================
Files 289 289
Lines 26463 29034 +2571
Branches 3922 4840 +918
==========================================
+ Hits 7194 8088 +894
- Misses 18999 20559 +1560
- Partials 270 387 +117
Continue to review full report at Codecov.
|
thelostone-mc
approved these changes
Apr 21, 2020
danlipert
approved these changes
Apr 21, 2020
octavioamu
suggested changes
Apr 21, 2020
| <script> | ||
| $('body').bootstrapTooltip({ | ||
| selector: '[data-toggle="tooltip"]' | ||
| }); | ||
| const csrftoken = jQuery("[name=csrfmiddlewaretoken]").val(); | ||
| document.keywords = {{ keywords | safe }}; | ||
| document.is_registered = {{ is_registered | safe }}; | ||
| document.is_registered = JSON.parse(document.getElementById('hackathon-registration').textContent); |
There was a problem hiding this comment.
where is this element with id hackathon-registration ?
octavioamu
suggested changes
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refers/Fixes
Issue with adding members to channel, users who have left the chat experience halt the mass adding of hackers.
Testing