-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: redo search UI #6419
feat: redo search UI #6419
Conversation
5bca917
to
6874973
Compare
Codecov Report
@@ Coverage Diff @@
## master #6419 +/- ##
==========================================
+ Coverage 27.20% 27.64% +0.44%
==========================================
Files 290 287 -3
Lines 26540 28117 +1577
Branches 3930 4547 +617
==========================================
+ Hits 7219 7774 +555
- Misses 19055 19991 +936
- Partials 266 352 +86
Continue to review full report at Codecov.
|
da614df
to
fc19954
Compare
this is very awesome. good work! some feedback when i put on my user hat
|
fc19954
to
34488ea
Compare
Current Statewhen i click the magnifying glass, the cursor should go in the text field so i dont have to click ther when the results load i want to be able to tab through them with my arrow keys (right left on tabs with left/right andup /down on the existin gresutls) ✅ a 'loading indicator' while searching would be a nice ttouch. ✅ how many chars are required before serach in sent? i just typed 'fo' inthe search box and its not doing anything? is it thinking? is that not enough chars? idk? ✅ why is the default tab 'profiles'? seems that we should add a 'all results' tab or at least be smart enough to load the tab that has results https://bits.owocki.com/lluDmn7g ✅ is there a 'no results' view? https://bits.owocki.com/z8uxp4b8 |
3c6ee50
to
0e86e7c
Compare
@owocki so i had a lil bit of trouble with the first two ! |
Description
Refers/Fixes
#5835
Test
https://share.vidyard.com/watch/gjPeWcUnystHYCXSGJTRBN?