-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: fixup listen_for_web3_changes #6355
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6355 +/- ##
==========================================
+ Coverage 27.56% 27.65% +0.08%
==========================================
Files 282 282
Lines 26145 26200 +55
Branches 3849 3856 +7
==========================================
+ Hits 7208 7246 +38
- Misses 18672 18685 +13
- Partials 265 269 +4
Continue to review full report at Codecov.
|
@@ -1,4 +1,7 @@ | |||
/* eslint no-useless-concat: 0 */ // --> OFF | |||
window.addEventListener('load', function() { | |||
setInterval(listen_for_web3_changes, 5000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that this wont populate the web3 info for 5000ms after pageload. listen_for_web3_changes() should probably be called immediately upon load unless we re hoping that people dont interact with web3 for 5s.
@thelostone-mc what parts of grants did you test? would love to make sure that fund grant, cancel grant, new grant, AND edit grant all still work bc we'll def hear about it after deploy if not |
@thelostone-mc this one got missed (settings/tokens ) fixed at e8cd9ed https://gitcoincore.slack.com/archives/CAXQ7PT60/p1586549633106500 |
also 06bf49c |
This moved the
listen_for_web3_changes
to the files where it's needed as opposed to having it shared.jsFlows tested
✔️ Bounties
✔️ Tips
✔️ Townsquare PART 1 & PART 2
✔️ Kudos
✔️ Activities page PART 1 & PART 2
✔️ Grants