Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fixup listen_for_web3_changes #6355

Merged
merged 2 commits into from
Apr 2, 2020
Merged

refactor: fixup listen_for_web3_changes #6355

merged 2 commits into from
Apr 2, 2020

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Apr 2, 2020

This moved the listen_for_web3_changes to the files where it's needed as opposed to having it shared.js

Flows tested

✔️ Bounties
✔️ Tips
✔️ Townsquare PART 1 & PART 2
✔️ Kudos
✔️ Activities page PART 1 & PART 2
✔️ Grants

@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #6355 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6355      +/-   ##
==========================================
+ Coverage   27.56%   27.65%   +0.08%     
==========================================
  Files         282      282              
  Lines       26145    26200      +55     
  Branches     3849     3856       +7     
==========================================
+ Hits         7208     7246      +38     
- Misses      18672    18685      +13     
- Partials      265      269       +4
Impacted Files Coverage Δ
...eting/management/commands/assemble_leaderboards.py 40.48% <0%> (ø) ⬆️
app/dashboard/views.py 11.21% <0%> (ø) ⬆️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️
app/kudos/models.py 53.65% <0%> (+2.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deb9e8f...44b0f68. Read the comment docs.

@thelostone-mc thelostone-mc merged commit be55700 into master Apr 2, 2020
@@ -1,4 +1,7 @@
/* eslint no-useless-concat: 0 */ // --> OFF
window.addEventListener('load', function() {
setInterval(listen_for_web3_changes, 5000);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that this wont populate the web3 info for 5000ms after pageload. listen_for_web3_changes() should probably be called immediately upon load unless we re hoping that people dont interact with web3 for 5s.

@owocki
Copy link
Contributor

owocki commented Apr 2, 2020

@thelostone-mc what parts of grants did you test? would love to make sure that fund grant, cancel grant, new grant, AND edit grant all still work bc we'll def hear about it after deploy if not

@owocki
Copy link
Contributor

owocki commented Apr 10, 2020

@thelostone-mc this one got missed (settings/tokens )

fixed at e8cd9ed https://gitcoincore.slack.com/archives/CAXQ7PT60/p1586549633106500

@owocki
Copy link
Contributor

owocki commented Apr 10, 2020

also 06bf49c

@thelostone-mc thelostone-mc deleted the derp_fix branch June 27, 2020 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants