-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors 3 requests down to 1 #634
Conversation
Codecov Report
@@ Coverage Diff @@
## master #634 +/- ##
==========================================
- Coverage 34.12% 34.07% -0.05%
==========================================
Files 90 90
Lines 4985 4942 -43
Branches 576 569 -7
==========================================
- Hits 1701 1684 -17
+ Misses 3217 3195 -22
+ Partials 67 63 -4
Continue to review full report at Codecov.
|
yay! tests passing... @mbeacom can i get an 👀 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
yay! note to self: it'll probably make sends to refactor the |
💯 |
Description
Refactors the requests for title, desc, and keywords into one request to save on rate limit / overhead of each request.
Checklist
Affected core subsystem(s)
ui
Testing
tested frontend