Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naive std bounties cross chain #6302

Merged
merged 4 commits into from
Mar 26, 2020
Merged

Conversation

danlipert
Copy link
Contributor

Description

This PR is a simple, but inelegant fix for issues where cross chain bounties have the wrong projects attached

Refers/Fixes
Testing

Tested locally w/ prod data

@danlipert danlipert changed the base branch from master to stable March 26, 2020 11:12
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #6302 into stable will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable    #6302      +/-   ##
==========================================
- Coverage   28.24%   28.16%   -0.08%     
==========================================
  Files         278      278              
  Lines       25745    25950     +205     
  Branches     3786     3875      +89     
==========================================
+ Hits         7271     7310      +39     
- Misses      18191    18344     +153     
- Partials      283      296      +13
Impacted Files Coverage Δ
app/dashboard/models.py 50.53% <100%> (+0.09%) ⬆️
...eting/management/commands/assemble_leaderboards.py 40.48% <0%> (ø) ⬆️
app/dashboard/views.py 11.31% <0%> (ø) ⬆️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️
app/grants/views.py 15.94% <0%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af9c8d1...35f5aa7. Read the comment docs.

@thelostone-mc thelostone-mc merged commit b94e721 into stable Mar 26, 2020
@thelostone-mc thelostone-mc deleted the naive-std-bounties-cross-chain branch June 27, 2020 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants