Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace match_direction -> is_positive_vote #6272

Merged
merged 5 commits into from
Mar 22, 2020

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Mar 21, 2020

Description
  • Makes query faster shifting from Char to Boolean
  • Updates all references from match_direction to is_positive_vote
  • handle corner case when first contribution is negative in clr

@codecov
Copy link

codecov bot commented Mar 21, 2020

Codecov Report

Merging #6272 into grants_round_5 will increase coverage by 0.32%.
The diff coverage is 16.66%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           grants_round_5    #6272      +/-   ##
==================================================
+ Coverage           27.91%   28.23%   +0.32%     
==================================================
  Files                 278      278              
  Lines               26837    25626    -1211     
  Branches             4225     3769     -456     
==================================================
- Hits                 7491     7235     -256     
+ Misses              19015    18109     -906     
+ Partials              331      282      -49
Impacted Files Coverage Δ
app/grants/views.py 15.68% <0%> (+0.02%) ⬆️
app/grants/models.py 48.34% <20%> (ø) ⬆️
app/grants/clr.py 14.94% <40%> (ø) ⬆️
app/dashboard/utils.py 42.23% <0%> (-2.1%) ⬇️
app/dashboard/views.py 11.33% <0%> (-1.77%) ⬇️
app/retail/emails.py 22.41% <0%> (-1.3%) ⬇️
...eting/management/commands/assemble_leaderboards.py 40.48% <0%> (ø) ⬆️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️
app/avatar/views_3d.py 9.59% <0%> (+0.53%) ⬆️
app/dashboard/embed.py 31.6% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d49f5e...60fd43a. Read the comment docs.

@owocki owocki merged commit 4698592 into gitcoinco:grants_round_5 Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants