Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: final BE wiring for grants #6268

Merged
merged 2 commits into from
Mar 21, 2020

Conversation

thelostone-mc
Copy link
Member

Description
  • remove random data as the algorithm has changed
  • filter contribution as +ve and -ve contributions
  • update code to ensure -ve voting is taken into account
  • update check to ensure algorithm runs when a grant has no -ve voting

- update code to ensure -ve voting is taken into account
@codecov
Copy link

codecov bot commented Mar 21, 2020

Codecov Report

Merging #6268 into grants_round_5 will increase coverage by 0.30%.
The diff coverage is 10.34%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           grants_round_5    #6268      +/-   ##
==================================================
+ Coverage           27.98%   28.29%   +0.30%     
==================================================
  Files                 278      278              
  Lines               26697    25539    -1158     
  Branches             4192     3745     -447     
==================================================
- Hits                 7472     7226     -246     
+ Misses              18894    18031     -863     
+ Partials              331      282      -49     
Impacted Files Coverage Δ
app/grants/management/commands/estimate_clr.py 0.00% <0.00%> (ø)
app/grants/clr.py 14.65% <10.00%> (-1.02%) ⬇️
app/grants/views.py 16.44% <14.28%> (+0.25%) ⬆️
app/dashboard/utils.py 42.23% <0.00%> (-2.10%) ⬇️
app/dashboard/views.py 11.33% <0.00%> (-1.77%) ⬇️
app/grants/admin.py 44.89% <0.00%> (-1.67%) ⬇️
app/retail/emails.py 22.41% <0.00%> (-1.30%) ⬇️
app/marketing/mails.py 11.98% <0.00%> (-0.04%) ⬇️
app/grants/urls.py 100.00% <0.00%> (ø)
...rketing/management/commands/no_applicants_email.py 0.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59961d7...fa94d09. Read the comment docs.

@@ -1092,7 +1093,15 @@ def predict_clr_v1(request, grant_id):
response['message'] = 'error: missing parameter amount'
return JsonResponse(response)

predicted_clr_match = predict_clr_live(grant, profile, float(amount))

match_direction = request.GET.get('match_direction', '+')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@owocki owocki merged commit c75ef8c into gitcoinco:grants_round_5 Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants