Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grants round 5 PR - MERGE MONDAY AM #6263

Merged
merged 59 commits into from
Mar 23, 2020
Merged

Grants round 5 PR - MERGE MONDAY AM #6263

merged 59 commits into from
Mar 23, 2020

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Mar 20, 2020 •
edited
Loading

This is a draft PR of

  • origin/frank-clr-r5-update
  • origin/frank-clr-r5-update
  • Kevins cleanup tasks

for Grants Round 5

tested end to end on

  • eth contribs
  • erc20 one time contribs
  • erc20 recurring contribs

details on where we at here https://gitcoincore.slack.com/archives/CBDTKB59A/p1584843947105500

owocki and others added 8 commits March 17, 2020 17:36
@owocki
task locking
fa07170
@owocki
errant 'or'
a81d6bd
@frankchen07 @thelostone-mc
squashed five commits, wip grants, added positive and negative voting…
2afe35a 
… calculations
@thelostone-mc
chore: clr prediction
344a20c 
- update clr cron to run every 5 min
- DRY predict_clr and predict_clr_live
- remove unused variable + fix broken code
- upate mgmt command + shift threshold & total pot to constants
  for each CLR type
@thelostone-mc
create endpoint to fetch predicted clr match
78fa5bf
@thelostone-mc
fixup API issues
58b9f5c
@owocki
landing page cleanup; grant page cleanup
1face6d
@owocki
Merge remote-tracking branch 'origin/frank-clr-r5-update' into grants…
8f6931a 
…_round_5
@owocki owocki mentioned this pull request Mar 20, 2020
Closed
@owocki owocki changed the title Grants round 5 - Frankenstein PR Grants round 5 - Frankenstein PR - WIP DO NOT MERGE Mar 20, 2020
@codecov
Copy link

codecov bot commented Mar 20, 2020 •
edited
Loading

Codecov Report

Merging #6263 into stable will decrease coverage by 0.33%.
The diff coverage is 16.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable    #6263      +/-   ##
==========================================
- Coverage   28.24%   27.91%   -0.34%     
==========================================
  Files         278      278              
  Lines       25403    26869    +1466     
  Branches     3718     4231     +513     
==========================================
+ Hits         7175     7500     +325     
- Misses      17947    19038    +1091     
- Partials      281      331      +50
Impacted Files Coverage Δ
app/app/urls.py 91.07% <ø> (ø) ⬆️
app/grants/urls.py 100% <ø> (ø) ⬆️
app/kudos/tasks.py 28.33% <0%> (-2.78%) ⬇️
app/economy/management/commands/get_prices.py 0% <0%> (ø) ⬆️
app/grants/management/commands/estimate_clr.py 0% <0%> (ø) ⬆️
app/app/settings.py 81.02% <100%> (+0.24%) ⬆️
app/grants/clr.py 14.94% <13.7%> (+14.94%) ⬆️
app/grants/views.py 15.61% <15.21%> (-0.82%) ⬇️
app/grants/management/commands/subminer.py 42.72% <33.33%> (-0.27%) ⬇️
app/grants/admin.py 44.89% <35.29%> (-1.67%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3530628...c5e3a58. Read the comment docs.

@owocki owocki changed the title Grants round 5 - Frankenstein PR - WIP DO NOT MERGE Grants round 5 - Frankenstein PR - MERGE MONDAY AM Mar 22, 2020
@owocki
Copy link
Contributor Author

owocki commented Mar 22, 2020

@thelostone-mc @octavioamu @danlipert grants goes live tomorrow at noon. letes get some 👀 on this for tomo

@owocki owocki changed the title Grants round 5 - Frankenstein PR - MERGE MONDAY AM Grants round 5 PR - MERGE MONDAY AM Mar 22, 2020
thelostone-mc
thelostone-mc approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lezzz rollllzzzzz

@owocki owocki merged commit 629ae64 into stable Mar 23, 2020
@thelostone-mc thelostone-mc deleted the grants_round_5 branch June 27, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thelostone-mc thelostone-mc thelostone-mc approved these changes

@danlipert danlipert danlipert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@owocki @danlipert @thelostone-mc @frankchen07 @zoek1 @santteegt