fix etc payout flow #6240
Merged
fix etc payout flow #6240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const apiUrlBounty = `/api/v1/bounty/payout/${fulfillment_id}`; | ||
|
|
||
| event.target.disabled = true; |
There was a problem hiding this comment.
what's the event.target for ? to disable the button ?
There was a problem hiding this comment.
yes, to avoid multiple request when double clicking.
| if (200 <= response.status && response.status <= 204) { | ||
| console.log('success', response); | ||
| vm.fetchBounty(); |
There was a problem hiding this comment.
do we need to fetchBounty ? wouldn't updating the state suffice ?
There was a problem hiding this comment.
is good to check if something else changed in that same time (ex other users submitting) also because to change the UI in the activity I will need to go to that exact fulfillment and do the modifications (is a viable option)
thelostone-mc
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
change pending by default after payout
close modal
refetch bounty data.
Refers/Fixes
Testing