-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Prod Timeout Worker Approve Timeout Errors #6238
Conversation
app/dashboard/views.py
Outdated
@@ -1776,7 +1776,10 @@ def helper_handle_approvals(request, bounty): | |||
|
|||
maybe_market_to_github(bounty, 'work_started', profile_pairs=bounty.profile_pairs) | |||
maybe_market_to_slack(bounty, 'worker_approved') | |||
maybe_market_to_user_slack(bounty, 'worker_approved') | |||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
longer term it may be a good idea to move these jobs to celery instead of pageload
cc @danlipert for an async review. merging this bc its prod and ppl cant approve certain workers |
Codecov Report
@@ Coverage Diff @@
## stable #6238 +/- ##
==========================================
+ Coverage 28.26% 28.29% +0.03%
==========================================
Files 278 278
Lines 25240 25256 +16
Branches 3695 3695
==========================================
+ Hits 7133 7147 +14
+ Misses 17826 17824 -2
- Partials 281 285 +4
Continue to review full report at Codecov.
|
Description
Uses a solution found here to prevent production timeout errors.
adds a re-usable decorator for managing those timeouts
Refers/Fixes
Production timeout errors on approving users
Testing
will yield