Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix web3connect in bounty create flow #6221

Merged

Conversation

thelostone-mc
Copy link
Member

Description
  • shows wallet connect checks only when ERC20/ETH is selected
  • prompts funder address when ETC is selected
  • removed ability to add funder address of payout popup

@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #6221 into new-bounty-detail will increase coverage by 10.67%.
The diff coverage is 0%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           new-bounty-detail    #6221       +/-   ##
======================================================
+ Coverage              17.65%   28.33%   +10.67%     
======================================================
  Files                    267      278       +11     
  Lines                  25119    25157       +38     
  Branches                3685     3688        +3     
======================================================
+ Hits                    4435     7127     +2692     
+ Misses                 20670    17751     -2919     
- Partials                  14      279      +265
Impacted Files Coverage Δ
app/dashboard/views.py 11.39% <0%> (+2.4%) ⬆️
...perftools/management/commands/create_page_cache.py 0% <0%> (ø) ⬆️
app/chat/management/commands/get_user_presence.py 0% <0%> (ø) ⬆️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️
app/retail/templatetags/is_in_list.py 66.66% <0%> (ø)
app/kudos/templatetags/kudos_extras.py 70% <0%> (ø)
app/retail/templatetags/strip_char.py 57.14% <0%> (ø)
app/retail/templatetags/is_in_list_type_iexact.py 66.66% <0%> (ø)
app/grants/templatetags/grants_extra.py 71.42% <0%> (ø)
app/retail/templatetags/matches.py 100% <0%> (ø)
... and 93 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1be2ac6...b6abead. Read the comment docs.

@thelostone-mc thelostone-mc merged commit b5592ef into gitcoinco:new-bounty-detail Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants