bug: fix up grant category #6153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thelostone-mc
commented
Mar 5, 2020
| @@ -103,7 +103,6 @@ def grants(request): | |||
| sort_by_clr_pledge_matching_amount = None | |||
| if 'match_pledge_amount_' in sort: | |||
| sort_by_clr_pledge_matching_amount = int(sort.split('amount_')[1]) | |||
| sort_by = 'pk' | |||
There was a problem hiding this comment.
this was removed cause it was not used anywhere
danlipert
approved these changes
Mar 9, 2020
octavioamu
approved these changes
Mar 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #6153 +/- ##
=========================================
+ Coverage 28.57% 28.6% +0.02%
=========================================
Files 276 276
Lines 24839 24836 -3
Branches 3634 3632 -2
=========================================
+ Hits 7098 7104 +6
+ Misses 17463 17455 -8
+ Partials 278 277 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/grants/new/grants//grants/<:grant-id>Demo
https://share.vidyard.com/watch/3WXLB5bzS9Dc4NGFyWLKwc
Refs: #5615