Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attach youtube video #6146

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Conversation

zoek1
Copy link
Contributor

@zoek1 zoek1 commented Mar 5, 2020

Description

The youtube api key was replaced with the YOUTUBE_KEY variable in settings.py.

Refers/Fixes

#6132

Testing

@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #6146 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6146      +/-   ##
==========================================
+ Coverage   28.62%   28.65%   +0.02%     
==========================================
  Files         275      275              
  Lines       24771    24772       +1     
  Branches     3622     3622              
==========================================
+ Hits         7091     7098       +7     
+ Misses      17403    17397       -6     
  Partials      277      277
Impacted Files Coverage Δ
app/app/context.py 67.03% <ø> (ø) ⬆️
app/app/settings.py 80.59% <100%> (+0.06%) ⬆️
app/dashboard/embed.py 31.6% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70474ee...ee644ea. Read the comment docs.

@octavioamu
Copy link
Contributor

ohh we totally forgot about that one. those are created on the google console right?

@octavioamu octavioamu merged commit 82e4628 into gitcoinco:master Mar 5, 2020
@zoek1
Copy link
Contributor Author

zoek1 commented Mar 5, 2020

Yep, in the Google console 👍

@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.10000 ETH (23.14 USD @ $231.42/ETH) has been granted to @zoek1 for this issue from @owocki. ⚡️

Nice work @zoek1! Your tip has automatically been deposited in the ETH address we have on file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants