Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing moment that prevents register ens subdoamin #6104

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

zoek1
Copy link
Contributor

@zoek1 zoek1 commented Mar 1, 2020

Description

Missing moment.js error on ENS page

image

Refers/Fixes

#6053

Testing

@zoek1
Copy link
Contributor Author

zoek1 commented Mar 1, 2020

Also, if requires someone to help on migrating ENS subdomains, I'll be happy to help 😄

@developerfred
Copy link
Contributor

Awesome, thanks @zoek1.

@thelostone-mc thelostone-mc merged commit 7ce067d into gitcoinco:master Mar 2, 2020
@owocki
Copy link
Contributor

owocki commented Mar 3, 2020

Also, if requires someone to help on migrating ENS subdomains, I'll be happy to help 😄

oh man i had no idea about this.. what do we need to do? is there a ticket?

@zoek1
Copy link
Contributor Author

zoek1 commented Mar 3, 2020

The instructions to migrate the domain as the owner are here @owocki: https://medium.com/the-ethereum-name-service/step-by-step-guide-to-migrating-your-eth-name-to-the-new-ens-registrar-5314431e22f2

At this moment, this is what display when one user query for gitcoin.eth
image

Here's the motivation behind the migration: https://medium.com/the-ethereum-name-service/ens-registry-migration-bug-fix-new-features-64379193a5a

Also, seems that to continue using ENS, the major change on gitcoin codebase requires changing the address of the new contract. After that the following steps could be:

  1. Migrate all subdomains in bulk with one script
  2. Implement at the ENS gitcoin page the option to upgrade the subdomain to the new contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants