feat: show confirmation before deleting comment #6089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walidmujahid
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
walidmujahid
force-pushed
the
comments-deletion-confirmation
branch
from
1eade8a to
cd1903b
Compare
Codecov Report
@@ Coverage Diff @@
## master #6089 +/- ##
==========================================
+ Coverage 28.88% 28.90% +0.02%
==========================================
Files 273 273
Lines 24273 24273
Branches 3561 3561
==========================================
+ Hits 7011 7017 +6
+ Misses 16979 16973 -6
Partials 283 283
Continue to review full report at Codecov.
|
walidmujahid
force-pushed
the
comments-deletion-confirmation
branch
2 times, most recently
from
029d8e7 to
da3e8a5
Compare
|
Looking good! |
octavioamu
approved these changes
Mar 2, 2020
walidmujahid
force-pushed
the
comments-deletion-confirmation
branch
from
da3e8a5 to
01df630
Compare
|
Thanks @walidmujahid great PR! Super clean and simple, and great demo video as well. Appreciate it! |
danlipert
approved these changes
Mar 4, 2020
developerfred
pushed a commit
to developerfred/web
that referenced
this pull request
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows a confirmation before deleting a comment and enables canceling.
Demo video: https://youtu.be/LfLDCPo3IjM
Closes #6084