caches activity view props to save about 0.5s per HTTPRequest to /activity on townsquare #6079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owocki
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
owocki
changed the title
danlipert
reviewed
Feb 26, 2020
|
|
||
| def generate_view_props_cache(self): | ||
| self.cached_view_props = self.view_props | ||
| self.cached_view_props = json.loads(json.dumps(self.cached_view_props, cls=EncodeAnything)) |
There was a problem hiding this comment.
So sketchy... I should have never put this in the codebase in the first place LOL 😆
There was a problem hiding this comment.
it seems entirely ridiculous to make that the default json encoder doesnt encode datetimes..
danlipert
approved these changes
Feb 26, 2020
Codecov Report
@@ Coverage Diff @@
## stable #6079 +/- ##
==========================================
+ Coverage 28.65% 28.91% +0.26%
==========================================
Files 272 272
Lines 24174 24213 +39
Branches 3537 3541 +4
==========================================
+ Hits 6927 7002 +75
+ Misses 16967 16905 -62
- Partials 280 306 +26
Continue to review full report at Codecov.
|
|
tests passing ... merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
caches activity view props to save about 0.5s per HTTPRequest to /activity on townsquare
Refers/Fixes
personal gripes with townsquare speed
Testing
tested locally, works fine.