Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds polls to newsfeed #6077

Merged
merged 3 commits into from
Mar 4, 2020
Merged

adds polls to newsfeed #6077

merged 3 commits into from
Mar 4, 2020

Conversation

IntoThe1337ness
Copy link

Description

this PR adds polls to gitcoin newsfeed to allow poll of userbase

Refers/Fixes

discussion in newsfeed about poll

Testing

Screen Recording 2020-02-19 at 05 48 PM

@IntoThe1337ness IntoThe1337ness mentioned this pull request Feb 25, 2020
Closed
@codecov
Copy link

codecov bot commented Feb 25, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@2d07789). Click here to learn what that means.
The diff coverage is 33.84%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6077   +/-   ##
=========================================
  Coverage          ?   28.93%           
=========================================
  Files             ?      272           
  Lines             ?    24176           
  Branches          ?     3546           
=========================================
  Hits              ?     6996           
  Misses            ?    16898           
  Partials          ?      282
Impacted Files Coverage Δ
app/app/context.py 68.53% <ø> (ø)
app/grants/urls.py 100% <ø> (ø)
app/inbox/signals.py 20% <ø> (ø)
app/app/urls.py 90.56% <ø> (ø)
app/retail/emails.py 22.41% <0%> (ø)
app/dashboard/export.py 58.69% <0%> (ø)
app/dashboard/tip_views.py 15.55% <0%> (ø)
app/marketing/mails.py 11.88% <0%> (ø)
app/townsquare/views.py 9.12% <0%> (ø)
app/app/settings.py 80.26% <100%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d07789...0a32e02. Read the comment docs.

owocki
owocki approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@owocki owocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM.. pumped to launch this

@octavioamu
Copy link
Contributor

Nice work!

danlipert
danlipert approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just one small comment

app/assets/v2/js/activity.js
// calc total
var answers = $this.parents('.poll_choices').find('span');

console.log(answers.length);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover log statement here

@octavioamu octavioamu merged commit 6ddffc8 into gitcoinco:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octavioamu octavioamu octavioamu approved these changes

@danlipert danlipert danlipert approved these changes

@owocki owocki owocki approved these changes

@thelostone-mc thelostone-mc Awaiting requested review from thelostone-mc thelostone-mc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IntoThe1337ness @octavioamu @owocki @danlipert