Give leaderboard have history charts (branched off master:) #6076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IntoThe1337ness
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6076 +/- ##
==========================================
+ Coverage 28.96% 29.22% +0.26%
==========================================
Files 272 272
Lines 24154 24339 +185
Branches 3536 3567 +31
==========================================
+ Hits 6996 7113 +117
- Misses 16876 16915 +39
- Partials 282 311 +29
Continue to review full report at Codecov.
|
owocki
reviewed
Feb 28, 2020
| @@ -56,8 +56,3 @@ def handle(self, *args, **options): | |||
| created_on__hour=1, | |||
| ).delete() | |||
| print(f'Stat: {result}') | |||
|
|
|||
| result = LeaderboardRank.objects.filter( | |||
There was a problem hiding this comment.
hmmm m we should stop doing this now.. gonna fix that here d84147c
octavioamu
approved these changes
Mar 4, 2020
danlipert
approved these changes
Mar 4, 2020
thelostone-mc
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this PR let leaderboard have history charts
Refers/Fixes
there is thread on twitter and townsquare about this. crates competitivness.
Testing
i tested local (See Below Comment)
Other Notes
we have to give the new cleanup DB script deploy first. Give data a few Week to AccumuLte.