-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sticky nav in some places #6074
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hows it look mo mobile?
…On Mon, Feb 24, 2020 at 3:58 PM Octavio Amuchástegui < ***@***.***> wrote:
Description
Sticky nav in townsquare and bounties explorer so people can access diff
areas an notifications without need to scroll to the top
[image: image]
<https://user-images.githubusercontent.com/1358093/75198708-06b0e080-5740-11ea-8f81-35298b3f315c.png>
Refers/Fixes Testing
------------------------------
You can view, comment on, or merge this pull request online at:
#6074
Commit Summary
- sticky nav in some places
File Changes
- *M* app/assets/v2/css/gitcoin.css
<https://github.com/gitcoinco/web/pull/6074/files#diff-0> (6)
- *M* app/dashboard/templates/dashboard/index.html
<https://github.com/gitcoinco/web/pull/6074/files#diff-1> (2)
- *M* app/townsquare/templates/townsquare/index.html
<https://github.com/gitcoinco/web/pull/6074/files#diff-2> (4)
Patch Links:
- https://github.com/gitcoinco/web/pull/6074.patch
- https://github.com/gitcoinco/web/pull/6074.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#6074?email_source=notifications&email_token=AAD5PCLIEVYXFDNVLPNP64DRERGKHA5CNFSM4K2U64WKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IP4RXEQ>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD5PCKWNKLYKLUGXDAH5DTRERGKHANCNFSM4K2U64WA>
.
_________________________________________
gitcoin is live and has generated over $3.5mm for Open Source Software - see
our results <https://gitcoin.co/results>
|
*on mobile
…On Mon, Feb 24, 2020 at 4:03 PM Kevin Owocki ***@***.***> wrote:
hows it look mo mobile?
On Mon, Feb 24, 2020 at 3:58 PM Octavio Amuchástegui <
***@***.***> wrote:
> Description
>
> Sticky nav in townsquare and bounties explorer so people can access diff
> areas an notifications without need to scroll to the top
> [image: image]
> <https://user-images.githubusercontent.com/1358093/75198708-06b0e080-5740-11ea-8f81-35298b3f315c.png>
> Refers/Fixes Testing
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> #6074
> Commit Summary
>
> - sticky nav in some places
>
> File Changes
>
> - *M* app/assets/v2/css/gitcoin.css
> <https://github.com/gitcoinco/web/pull/6074/files#diff-0> (6)
> - *M* app/dashboard/templates/dashboard/index.html
> <https://github.com/gitcoinco/web/pull/6074/files#diff-1> (2)
> - *M* app/townsquare/templates/townsquare/index.html
> <https://github.com/gitcoinco/web/pull/6074/files#diff-2> (4)
>
> Patch Links:
>
> - https://github.com/gitcoinco/web/pull/6074.patch
> - https://github.com/gitcoinco/web/pull/6074.diff
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#6074?email_source=notifications&email_token=AAD5PCLIEVYXFDNVLPNP64DRERGKHA5CNFSM4K2U64WKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IP4RXEQ>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAD5PCKWNKLYKLUGXDAH5DTRERGKHANCNFSM4K2U64WA>
> .
>
--
@owocki <http://www.twitter.com/owocki>
_________________________________________
gitcoin is live and has generated over $3.5mm for Open Source Software - see
our results <https://gitcoin.co/results>
_________________________________________
gitcoin is live and has generated over $3.5mm for Open Source Software - see
our results <https://gitcoin.co/results>
|
Codecov Report
@@ Coverage Diff @@
## master #6074 +/- ##
=======================================
Coverage 28.95% 28.95%
=======================================
Files 272 272
Lines 24138 24138
Branches 3530 3530
=======================================
Hits 6988 6988
+ Misses 16868 16864 -4
- Partials 282 286 +4
Continue to review full report at Codecov.
|
thelostone-mc
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sticky nav in townsquare and bounties explorer so people can access diff areas an notifications without need to scroll to the top
Refers/Fixes
Testing