Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ratings Sections #6073

Merged
merged 3 commits into from
Apr 29, 2020
Merged

Ratings Sections #6073

merged 3 commits into from
Apr 29, 2020

Conversation

molecula451
Copy link
Contributor

@molecula451 molecula451 commented Feb 24, 2020

Description

Instead expecting the bounty to be "done" and the user getting a feedback Request in [Work Submmited]. When the bounty turns [Work Submmited] It will ask the user for ratings in the [Work Submmited] Sections

Refers/Fixes

#5619

Testing

Tested and it's working locally

submitted

submit

@molecula451 molecula451 marked this pull request as ready for review February 24, 2020 21:22
@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #6073 into master will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6073      +/-   ##
==========================================
+ Coverage   27.26%   27.29%   +0.02%     
==========================================
  Files         287      287              
  Lines       26712    26712              
  Branches     3945     3945              
==========================================
+ Hits         7284     7290       +6     
+ Misses      19161    19155       -6     
  Partials      267      267              
Impacted Files Coverage Δ
app/dashboard/utils.py 43.53% <0.00%> (ø)
app/dashboard/views.py 11.12% <ø> (ø)
app/dashboard/embed.py 31.60% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e20741...99706b5. Read the comment docs.

@molecula451
Copy link
Contributor Author

the great @octavioamu :)

@octavioamu
Copy link
Contributor

@molecula451 is this ready or something is missing?

@octavioamu
Copy link
Contributor

@molecula451 is this ready or something is missing?

@molecula451 yes or no?

@molecula451
Copy link
Contributor Author

@molecula451 is this ready or something is missing?

I think this is a good solution to the problem. It will mostly ask for feedback on [Work Submmited] works instead of asking anytime for feedback even if you don't submit any work, just because you "applied"

@thelostone-mc thelostone-mc changed the title [WIP] Ratings Sections Ratings Sections Apr 29, 2020
@octavioamu
Copy link
Contributor

@molecula451 be aware if you left prs in draft or [WIP] then yes we are not going to review it, Think we are 3 devs reviewing all the PRs so we can't get on each of your PRs to guess if they are ready or not.
If you want a more agile review then make your part.

@danlipert danlipert merged commit 21a70e3 into gitcoinco:master Apr 29, 2020
@molecula451
Copy link
Contributor Author

@molecula451 be aware if you left prs in draft or [WIP] then yes we are not going to review it, Think we are 3 devs reviewing all the PRs so we can't get on each of your PRs to guess if they are ready or not.
If you want a more agile review then make your part.

Absolutely agree on your positiveness octavio thanks for clarifying everything honest. This will only make myself work in a sort better way for the whole repo and with you guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants