-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
townsquare: profile filter support #6064
Conversation
- replace checkbox with My Feed - enable feed filter for tribe/users with tab param
Codecov Report
@@ Coverage Diff @@
## master #6064 +/- ##
==========================================
- Coverage 28.96% 28.67% -0.29%
==========================================
Files 272 272
Lines 24111 25660 +1549
Branches 3525 4068 +543
==========================================
+ Hits 6983 7359 +376
- Misses 16847 17956 +1109
- Partials 281 345 +64
Continue to review full report at Codecov.
|
|
||
return '/?tab=' + tab + '&trending=' + trending; | ||
return '/?tab=' + tab + '&trending=' + trending + '&personal=' + personal; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be good to use string literals here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove this as we are making personal feed a separate tab now.
Description
http://localhost:8000/?tab=my_feed // logged in users feed
http://localhost:8000/?tab=gitcoinco // orgs feed
http://localhost:8000/?tab=danliper // dan's feed
Refers/Fixes
This is built on top of #6054 by @sounak98
Testing
https://share.vidyard.com/watch/1JhpFmhR4bk5UP4jZV1tMW?