Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

townsquare: profile filter support #6064

Merged
merged 5 commits into from
Feb 26, 2020
Merged

townsquare: profile filter support #6064

merged 5 commits into from
Feb 26, 2020

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Feb 24, 2020

Description
  • fix bug when tip is not associated with comment / activity
  • replace checkbox with My Feed
  • enable feed filter for tribe/users with tab param

http://localhost:8000/?tab=my_feed // logged in users feed
http://localhost:8000/?tab=gitcoinco // orgs feed
http://localhost:8000/?tab=danliper // dan's feed

Refers/Fixes

This is built on top of #6054 by @sounak98

Testing

https://share.vidyard.com/watch/1JhpFmhR4bk5UP4jZV1tMW?

@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #6064 into master will decrease coverage by 0.28%.
The diff coverage is 21.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6064      +/-   ##
==========================================
- Coverage   28.96%   28.67%   -0.29%     
==========================================
  Files         272      272              
  Lines       24111    25660    +1549     
  Branches     3525     4068     +543     
==========================================
+ Hits         6983     7359     +376     
- Misses      16847    17956    +1109     
- Partials      281      345      +64
Impacted Files Coverage Δ
app/marketing/mails.py 16.34% <0%> (+4.45%) ⬆️
app/retail/views.py 26.27% <0%> (+3.97%) ⬆️
app/retail/emails.py 22.41% <0%> (ø) ⬆️
app/townsquare/views.py 8.97% <0%> (-0.52%) ⬇️
app/grants/views.py 16.59% <100%> (+0.34%) ⬆️
app/townsquare/clr.py 13.18% <18.18%> (+0.54%) ⬆️
app/dashboard/tasks.py 38.63% <22.22%> (-4.23%) ⬇️
app/townsquare/models.py 62.91% <30.76%> (+1.24%) ⬆️
app/dashboard/models.py 54.53% <8.69%> (-0.21%) ⬇️
app/dashboard/views.py 13.62% <81.81%> (+1.82%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb4255e...40431e4. Read the comment docs.


return '/?tab=' + tab + '&trending=' + trending;
return '/?tab=' + tab + '&trending=' + trending + '&personal=' + personal;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be good to use string literals here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this as we are making personal feed a separate tab now.

app/townsquare/templates/townsquare/index.html Outdated Show resolved Hide resolved
@thelostone-mc thelostone-mc merged commit 47e3c31 into master Feb 26, 2020
@thelostone-mc thelostone-mc deleted the pro branch June 27, 2020 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants