Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a gitcoin user, I would like to see the responses to my post in the Notifications. #6045

Merged
merged 2 commits into from
Feb 25, 2020
Merged

As a gitcoin user, I would like to see the responses to my post in the Notifications. #6045

merged 2 commits into from
Feb 25, 2020

Conversation

zoek1
Copy link
Contributor

@zoek1 zoek1 commented Feb 21, 2020 •
edited
Loading

Description

Get notifications from someone pinging me in the town square or for responses to my post

  • I receive a notification when someone pings me on a post
  • I receive a notification when someone comments on my posts
  • I receive a notification when someone pings me on some comments
Refers/Fixes

#5943

Testing

FireShot Capture 001 - Home - Gitcoin - localhost

@codecov
Copy link

codecov bot commented Feb 21, 2020 •
edited
Loading

Codecov Report

Merging #6045 into master will increase coverage by 0.03%.
The diff coverage is 32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6045      +/-   ##
==========================================
+ Coverage   28.96%   28.99%   +0.03%     
==========================================
  Files         272      272              
  Lines       24085    24125      +40     
  Branches     3518     3523       +5     
==========================================
+ Hits         6976     6996      +20     
- Misses      16828    16847      +19     
- Partials      281      282       +1
Impacted Files Coverage Δ
app/inbox/models.py 93.33% <ø> (ø) ⬆️
app/townsquare/models.py 61.67% <ø> (ø) ⬆️
app/app/utils.py 22.69% <20%> (-0.05%) ⬇️
app/inbox/utils.py 36% <28.57%> (-39%) ⬇️
app/retail/views.py 22.5% <33.33%> (+0.05%) ⬆️
app/inbox/signals.py 24.13% <36.84%> (+4.13%) ⬆️
app/marketing/mails.py 12.03% <50%> (+0.14%) ⬆️
app/dashboard/embed.py 31.6% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a869e4d...0380c42. Read the comment docs.

@gitcoinbot gitcoinbot mentioned this pull request Feb 21, 2020
Closed
octavioamu
octavioamu suggested changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey zoek Just tested on my local, I just received notifications when someone tag my users not on likes new comments are placed on the bottom of notifications array.
Another thing I noticed is you didn't use the signals, probably I should have explained that on the issue but in the folder inbox you have a signals.py files to actually add the signal of any notification and do all the dirty job for you.

app/assets/v2/js/notifications.js Outdated Show resolved Hide resolved
octavioamu
octavioamu suggested changes Feb 21, 2020
View reviewed changes
app/inbox/models.py
@@ -55,6 +55,8 @@ class Notification(SuperModel):
('new_milestone', 'New Milestone'),
('update_milestone', 'Updated Milestone'),
('new_kudos', 'New Kudos'),
('new_mention', 'New Mention'),
('new_post_comment', 'New comment'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new_like

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, i'll add it!

@octavioamu
Copy link
Contributor

Really nice and supper excited with this I have another on going PR I will integrate with this to add the notifications to the browser

@zoek1 zoek1 requested a review from octavioamu February 24, 2020 08:28
octavioamu
octavioamu approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, tested locally

thelostone-mc
thelostone-mc approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fuck nice :D
excited

@thelostone-mc thelostone-mc merged commit 1f8042a into gitcoinco:master Feb 25, 2020
@sebastiantf sebastiantf mentioned this pull request Apr 17, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thelostone-mc thelostone-mc thelostone-mc approved these changes

@octavioamu octavioamu octavioamu approved these changes

@danlipert danlipert Awaiting requested review from danlipert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zoek1 @octavioamu @owocki @thelostone-mc