Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix org avatars #6029

Merged
merged 2 commits into from
Feb 20, 2020
Merged

Fix org avatars #6029

merged 2 commits into from
Feb 20, 2020

Conversation

KiChjang
Copy link
Contributor

Description

Ensure that organizations have proper avatars pulled from GitHub

Refers/Fixes

Fixes #5992.

Testing

Manually tested by removing my own avatar and allowing the backend to automatically resync

@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #6029 into master will increase coverage by 0.06%.
The diff coverage is 41.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6029      +/-   ##
==========================================
+ Coverage   28.84%   28.91%   +0.06%     
==========================================
  Files         272      272              
  Lines       24004    24019      +15     
  Branches     3503     3505       +2     
==========================================
+ Hits         6923     6944      +21     
+ Misses      16806    16796      -10     
- Partials      275      279       +4
Impacted Files Coverage Δ
app/dashboard/models.py 55.18% <25%> (-0.15%) ⬇️
app/avatar/utils.py 14.5% <80%> (+1.39%) ⬆️
app/git/utils.py 41.17% <0%> (+1.64%) ⬆️
app/dashboard/embed.py 31.6% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 010d4b6...6a9019e. Read the comment docs.

@gitcoinbot gitcoinbot mentioned this pull request Feb 20, 2020
Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@octavioamu octavioamu merged commit 187e445 into gitcoinco:master Feb 20, 2020
@KiChjang KiChjang deleted the fix-org-avatars branch February 20, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong orgs avatars
3 participants