fix: duplicate activity comments #6008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When commenting/replying on activities/status posts, comments can be duplicated by hitting the return key more than once: https://youtu.be/Btage0nfqzY Disabling the textarea for every call of post_comment would solve the duplication problem. fixes gitcoinco#6007
walidmujahid
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
Codecov Report
@@ Coverage Diff @@
## master #6008 +/- ##
==========================================
+ Coverage 28.86% 28.89% +0.02%
==========================================
Files 272 272
Lines 23978 23978
Branches 3498 3498
==========================================
+ Hits 6922 6928 +6
+ Misses 16781 16775 -6
Partials 275 275
Continue to review full report at Codecov.
|
thelostone-mc
approved these changes
Feb 19, 2020
danlipert
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When commenting/replying on activities/status posts, comments can be duplicated by hitting the return key more than once Disabling the textarea for every call of post_comment would solve the duplication problem.
closes #6007