Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "shift-enter" function to townsquare - New lines can now be made #6006

Merged

Conversation

walidmujahid
Copy link
Contributor

Adds 'shift+enter' as an option to create new lines in Status/Activity comments.

Part of Town Square Imrovmenets: #6003

Demo: https://youtu.be/GQ-jEc4K31o

Adds 'shift+enter' as an option to create a new line
in Status/Activity comments.

Part of Town Square Imrovmenets: gitcoinco#6003
@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #6006 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6006      +/-   ##
==========================================
+ Coverage   28.86%   28.89%   +0.02%     
==========================================
  Files         272      272              
  Lines       23978    23978              
  Branches     3498     3498              
==========================================
+ Hits         6922     6928       +6     
+ Misses      16781    16775       -6     
  Partials      275      275
Impacted Files Coverage Δ
app/dashboard/embed.py 31.6% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9e4d40...02c8410. Read the comment docs.

@walidmujahid walidmujahid force-pushed the activity-comments-newline branch from 3e66c97 to 5f4b625 Compare February 18, 2020 08:03
@walidmujahid walidmujahid requested review from owocki and removed request for owocki February 18, 2020 08:04
Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niceee ^_^

@thelostone-mc thelostone-mc merged commit a8ad43f into gitcoinco:master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants