Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update tribe landing page #5998

Merged
merged 12 commits into from
Feb 20, 2020
Merged

feat: update tribe landing page #5998

merged 12 commits into from
Feb 20, 2020

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Feb 17, 2020

Description

Landing Page

  • updated the landing page based on new design
  • compressed svgs

TODO: wire in redirection to typeform / mail when user selects the plan
(pending @vs77bb / @PixelantDesign )

User Directory

  • toggle filter visibility if the persona is tribes
  • toggle banner for tribes
  • refactor template
  • updated the layout for tribe card
  • custom url for only tribes (/tribes/explore) [ filters are hidden by default ]

Video : https://share.vidyard.com/watch/68GZm6kMa9KPAETR84mS1Q?

TODO: add in custom filters for tribes page
(pending @PixelantDesign )

screencapture-localhost-8000-tribes-2020-02-17-13_24_48

@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #5998 into master will decrease coverage by 0.02%.
The diff coverage is 35.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5998      +/-   ##
==========================================
- Coverage   28.86%   28.84%   -0.03%     
==========================================
  Files         272      272              
  Lines       23978    24026      +48     
  Branches     3498     3506       +8     
==========================================
+ Hits         6922     6931       +9     
- Misses      16781    16819      +38     
- Partials      275      276       +1
Impacted Files Coverage Δ
app/app/urls.py 90.56% <ø> (ø) ⬆️
app/retail/views.py 22.44% <14.28%> (-0.08%) ⬇️
app/dashboard/views.py 11.79% <42.85%> (+0.21%) ⬆️
app/townsquare/views.py 9.52% <0%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74bc15a...a0220f0. Read the comment docs.

Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left just a few comments, looking good

app/assets/v2/css/users.css Outdated Show resolved Hide resolved
}

.testimonial-section .testimonial-photo-container {
top: -2rem;
left: 0;
right: 0;
}

#pro,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just

#pro {
    color:white
    background-color: #170640;
}  

or with a class always is better.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ Cause the h2 + others have have a colo black assigned to them in plans.css
This is just for users and hence the reason for writing it up

@thelostone-mc thelostone-mc merged commit 476adc5 into master Feb 20, 2020
@thelostone-mc thelostone-mc deleted the trib branch June 27, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants