Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ability to join tribe in townsquare activity feed #5994

Merged
merged 1 commit into from
Feb 20, 2020
Merged

add ability to join tribe in townsquare activity feed #5994

merged 1 commit into from
Feb 20, 2020

Conversation

danlipert
Copy link
Contributor

Description

This PR adds a join tribe button to tribe activity entries in townsquare

Screen Shot 2020-02-17 at 2 04 58 AM

Refers/Fixes

n/a

Testing

Tested locally

thelostone-mc
thelostone-mc approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !
could we removed the commented out code though ?

@thelostone-mc thelostone-mc merged commit e0ebf86 into stable Feb 20, 2020
@thelostone-mc thelostone-mc deleted the townsquare-join-tribe-activity branch June 27, 2020 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thelostone-mc thelostone-mc thelostone-mc approved these changes

@octavioamu octavioamu octavioamu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danlipert @owocki @octavioamu @thelostone-mc