-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple Web3 wallets #5978
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5978 +/- ##
==========================================
+ Coverage 18.38% 27.22% +8.83%
==========================================
Files 278 290 +12
Lines 26385 26542 +157
Branches 3918 3930 +12
==========================================
+ Hits 4852 7227 +2375
+ Misses 21521 19049 -2472
- Partials 12 266 +254
Continue to review full report at Codecov.
|
91a3401
to
a883fe4
Compare
69e62c2
to
9da3aa2
Compare
9da3aa2
to
05a1e25
Compare
@KiChjang excited for this! Let us know when its ready for review |
@KiChjang btw, in the past we made a Gitcoin themed modal; we can deploy that if you send me the test and live api keys which you can find in the Fortmatic dashboard. Feel free to dm me on Telegram @faridrached or email me on [email protected]. Thanks! |
@danlipert Sorry I wasn't clear; this is ready for review. @faridrached I am currently using my own personal test and live API keys on Fortmatic, and I'm suspecting that I should use the one for gitcoin instead? If so, then gitcoin would have to provide one. |
Yes, its wiser if someone from Gitcoin creates an account and shares the key indeed. Perhaps @danlipert or @thelostone-mc? |
@KiChjang ill create my own key for the gitcoin production deployment. just make it configurable in the .env file (thats where we store secretse on the gitcoin app)
its such great to see that you've done this testing.. yay! did u test in chrome/metamask? brave? safari? |
@owocki I actually did my testing on Firefox, because that's the only browser that didn't have any issues with the Authereum integration. The specific issued I encountered while testing Authereum on Chrome is that I'll push a commit up soon to make it configurable via |
Hi @KiChjang curious if you also tested Fortmatic on the mentioned browsers? |
Tested on my local but didn't worked. |
@octavioamu Ah, sending tips through townsquare is a flow that I didn't test, but I tried to dig into it and find the root cause, and it looks like to me that the API call to |
@octavioamu I did a rebase to master on this PR and the Send Tip flow should work as intended. Please re-review. |
@faridrached I've tested Fortmatic on Firefox only, and everything worked fine. |
* Vendor Web3Connect, Fortmatic and Authereum into frontend code * Ensure Send Tip user flow works - Refactor web3.eth.coinbase and web3.eth.accounts to use their corresponding async API counterparts
…e on all HTML pages
@danlipert it's rebased |
@KiChjang @faridrached looks like this has been merged. we should get it testeed to make sure no regressions + looks good then maybe start doing some marketing :) |
Great job. As soon as its ready to go in production, then lets definitely market it! |
corresponding async API counterparts
Description
Allow user to choose the web3 wallet to connect to Gitcoin with.
Refers/Fixes
Fixes #5954, fixes #5909.
Testing
Manual smoke testing has been done on the following flows: