export earnings, txid, token name/value, payee location #5957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owocki
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
thelostone-mc
approved these changes
Apr 21, 2020
octavioamu
reviewed
Apr 21, 2020
| profile = request.user.profile | ||
| earnings = profile.earnings if export_type == 'earnings' else profile.sent_earnings | ||
| earnings = earnings.all().order_by('-created_on') | ||
| earnings = earnings.filter(network='mainnet').order_by('-created_on') |
There was a problem hiding this comment.
shouldn't this be dynamic to work on local also ?
There was a problem hiding this comment.
nah it's just for export -> should be fine
octavioamu
approved these changes
Apr 22, 2020
danlipert
approved these changes
Apr 22, 2020
|
@owocki CI fail :| |
|
@thelostone-mc just deployed a fix for tests |
app/dashboard/models.py
Outdated
| @@ -1759,10 +1759,13 @@ def psave_tip(sender, instance, **kwargs): | |||
| def postsave_tip(sender, instance, created, **kwargs): | |||
| is_valid = instance.sender_profile != instance.recipient_profile and instance.txid | |||
| if instance.pk and is_valid: | |||
| value_true = 0 | |||
| value_true = 0 | |||
There was a problem hiding this comment.
^ @owocki value_usd :P
I'll fix it up and see
Codecov Report
@@ Coverage Diff @@
## master #5957 +/- ##
==========================================
+ Coverage 27.08% 27.11% +0.02%
==========================================
Files 290 290
Lines 26635 26642 +7
Branches 3943 3943
==========================================
+ Hits 7214 7223 +9
+ Misses 19154 19148 -6
- Partials 267 271 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
export earnings, txid, token name/value, payee location in earnings export
Refers/Fixes
customer request
Testing
tested locally