Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3box integration #5947

Merged
merged 33 commits into from
Feb 5, 2020
Merged

3box integration #5947

merged 33 commits into from
Feb 5, 2020

Conversation

thelostone-mc
Copy link
Member

Description

Moved over from #5640

@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@9f0a150). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5947   +/-   ##
=========================================
  Coverage          ?   28.94%           
=========================================
  Files             ?      271           
  Lines             ?    23648           
  Branches          ?     3436           
=========================================
  Hits              ?     6846           
  Misses            ?    16525           
  Partials          ?      277
Impacted Files Coverage Δ
app/dashboard/views.py 11.61% <0%> (ø)
app/dashboard/models.py 55.22% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f0a150...e5ef20a. Read the comment docs.

@octavioamu octavioamu merged commit 3befd40 into master Feb 5, 2020
@owocki
Copy link
Contributor

owocki commented Feb 5, 2020

did testing of this fail?? cc @think-in-universe @thelostone-mc

@think-in-universe
Copy link
Contributor

think-in-universe commented Feb 6, 2020

@owocki yes. we met some testing failure in the production. We tested together with 3Box team with some mock data in dev environment last time, but some cases are not well tested without sufficient mock data. Let's fix here.

@thelostone-mc I have created a PR #5955 to fix the issue introduced in #5947. But I failed to create mock bounties data in my local dev environment after tried for quite some times, and could you please help test before you merge the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants