-
-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3box integration #5947
3box integration #5947
Conversation
Merge latest code from gitcoinco/web
Codecov Report
@@ Coverage Diff @@
## master #5947 +/- ##
=========================================
Coverage ? 28.94%
=========================================
Files ? 271
Lines ? 23648
Branches ? 3436
=========================================
Hits ? 6846
Misses ? 16525
Partials ? 277
Continue to review full report at Codecov.
|
did testing of this fail?? cc @think-in-universe @thelostone-mc |
@owocki yes. we met some testing failure in the production. We tested together with 3Box team with some mock data in dev environment last time, but some cases are not well tested without sufficient mock data. Let's fix here. @thelostone-mc I have created a PR #5955 to fix the issue introduced in #5947. But I failed to create mock bounties data in my local dev environment after tried for quite some times, and could you please help test before you merge the fix? |
Description
Moved over from #5640