Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests 252020 #5944

Merged
merged 4 commits into from
Feb 5, 2020
Merged

Fix tests 252020 #5944

merged 4 commits into from
Feb 5, 2020

Conversation

danlipert
Copy link
Contributor

Description

This PR allows tests to pass again

Refers/Fixes
Testing

@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #5944 into master will decrease coverage by 0.74%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5944      +/-   ##
==========================================
- Coverage   29.23%   28.48%   -0.75%     
==========================================
  Files         270      270              
  Lines       23290    24265     +975     
  Branches     3387     3721     +334     
==========================================
+ Hits         6808     6913     +105     
- Misses      16189    17039     +850     
- Partials      293      313      +20
Impacted Files Coverage Δ
...eting/management/commands/assemble_leaderboards.py 42.2% <0%> (-11.62%) ⬇️
app/grants/models.py 46.34% <0%> (-5.85%) ⬇️
app/avatar/views_3d.py 14.51% <0%> (-3.98%) ⬇️
app/git/utils.py 39.52% <0%> (-0.24%) ⬇️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️
app/dashboard/views.py 13.45% <0%> (+1.85%) ⬆️
app/dashboard/embed.py 28.16% <0%> (+2.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05c5145...86bd61b. Read the comment docs.

@thelostone-mc thelostone-mc merged commit cd4b961 into master Feb 5, 2020
@thelostone-mc thelostone-mc deleted the fix-tests-252020 branch June 27, 2020 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants