fix search css and js bugs #5938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good; thanks for the cleanup! |
app/assets/v2/css/search.css
Outdated
| background-color: #fafafa; | ||
| color: #5d666f; | ||
| cursor: pointer; | ||
| text-decoration: none; | ||
| border: none; | ||
| border-left: 5px solid #3E00FF; | ||
| /* border: none; */ |
There was a problem hiding this comment.
@octavioamu LGTM !
Do we wanna raise this against master give we'll be deploying stuff today ?
Codecov Report
@@ Coverage Diff @@
## stable #5938 +/- ##
==========================================
+ Coverage 17.52% 17.52% +<.01%
==========================================
Files 259 259
Lines 23133 23806 +673
Branches 3372 3645 +273
==========================================
+ Hits 4053 4171 +118
- Misses 19070 19587 +517
- Partials 10 48 +38
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix some bugs:
nav across the site with diff styles
select2 classes
Add gc-search class to search module to avoid collisions.
Add responsive css
Css changes to avoid flicking spaces.
Add scroll to handle many results on box.
Refers/Fixes
Testing
Tested diff pages and nav sizes.