Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create wallpaper dir if doesnt exist #5932

Merged
merged 2 commits into from
Feb 5, 2020
Merged

Conversation

danlipert
Copy link
Contributor

Description

This PR creates a directory to store the profile wallpaper if it doesn't exist - this will happen on a newly deployed server so now one less thing to keep track of when putting up a new box

Refers/Fixes

#5921

Testing

untested but non-destructive

@owocki
Copy link
Contributor

owocki commented Feb 3, 2020

one thing i didnt realize from the other thread.. the wallpaper dir needs to copy the wallpapers over from /assets/wallpapers too (or collectstatic should run).. otherwise the API call will not return anything

@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #5932 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5932   +/-   ##
=======================================
  Coverage   17.51%   17.51%           
=======================================
  Files         259      259           
  Lines       23172    23172           
  Branches     3372     3372           
=======================================
  Hits         4059     4059           
+ Misses      19103    19099    -4     
- Partials       10       14    +4
Impacted Files Coverage Δ
...eting/management/commands/assemble_leaderboards.py 20.96% <0%> (ø) ⬆️
app/dashboard/views.py 9.34% <0%> (ø) ⬆️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a22440...4e82fee. Read the comment docs.

@danlipert
Copy link
Contributor Author

@owocki thanks for the heads up - i moved the directory creation call to before collectstatic getting ran

@owocki
Copy link
Contributor

owocki commented Feb 4, 2020

note that collectstatic doesnt run on all servers tho :P typically just one server..

@thelostone-mc thelostone-mc merged commit 05c5145 into master Feb 5, 2020
@thelostone-mc thelostone-mc deleted the wallpaper-dir-on-deploy branch June 27, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants