Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to suggest bounties via tribes #5927

Merged
merged 4 commits into from
Feb 5, 2020

Conversation

thelostone-mc
Copy link
Member

Description

TRIBE MEMBER

  • Default message if no bounties requested
  • Post Bounty requests
  • Auto add as tribe member

TRIBE OWNER

  • Default message if priority is not set
  • Default message if no bounties requested
  • Update priority + publish to townsqaure
  • Fund/ Reject Bounty requests

Also, introduces 2 new REST Endpoints with validation for bounty requests

Refers/Fixes

- create bounty request flow
- display suggested bounties
- reject bounty requests
@thelostone-mc thelostone-mc changed the title feat: base commit for suggest bounties feat: ability to suggest bounties via tribes Feb 3, 2020
@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #5927 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5927   +/-   ##
=======================================
  Coverage   17.44%   17.44%           
=======================================
  Files         259      259           
  Lines       23305    23305           
  Branches     3396     3396           
=======================================
  Hits         4065     4065           
  Misses      19230    19230           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a39627...73161c5. Read the comment docs.

@@ -389,6 +390,13 @@ def create_new_bounty(old_bounties, bounty_payload, bounty_details, bounty_id):
else:
raise UnsupportedSchemaException('No webReferenceURL found. Cannot continue!')

try:
bounty_request = BountyRequest.objects.get(github_url=url, status='o')
bounty_request.status = 'f'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is that status 'f' ?

Copy link
Member Author

@thelostone-mc thelostone-mc Feb 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

status f -> is status funded

@@ -47,7 +47,7 @@
{% endif %}
</div>

<div class="container-fluid bg-light">
<div class="container-fluid">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing bg-light will turn the bg white right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just left some comments

@thelostone-mc thelostone-mc merged commit b38db35 into gitcoinco:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants