Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xss fixes majortomsec #5926

Merged
merged 6 commits into from
Feb 4, 2020
Merged

Xss fixes majortomsec #5926

merged 6 commits into from
Feb 4, 2020

Conversation

danlipert
Copy link
Contributor

Description

This PR fixes some POST/GET and potential XSS issues

Refers/Fixes

#5183

Testing

tested by OG bounty hunter

@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #5926 into master will decrease coverage by 0.07%.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5926      +/-   ##
==========================================
- Coverage   29.39%   29.32%   -0.08%     
==========================================
  Files         270      270              
  Lines       23090    23106      +16     
  Branches     3353     3358       +5     
==========================================
- Hits         6788     6775      -13     
- Misses      16013    16033      +20     
- Partials      289      298       +9
Impacted Files Coverage Δ
app/dashboard/views.py 11.61% <0%> (-0.02%) ⬇️
app/kudos/views.py 14.91% <11.11%> (-0.12%) ⬇️
app/dashboard/tip_views.py 15.9% <11.11%> (-0.22%) ⬇️
app/marketing/views.py 11.11% <11.11%> (-0.16%) ⬇️
app/dashboard/utils.py 40.81% <50%> (+0.03%) ⬆️
...eting/management/commands/assemble_leaderboards.py 50.42% <0%> (-3.4%) ⬇️
app/app/utils.py 22.07% <0%> (-0.67%) ⬇️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc7d41e...25fa74a. Read the comment docs.

@thelostone-mc thelostone-mc merged commit 1465f3a into master Feb 4, 2020
@thelostone-mc thelostone-mc deleted the xss-fixes-majortomsec branch June 27, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants