Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute GeoIP files in dist/ because they are not downloadable anymore #5924

Merged
merged 2 commits into from
Feb 4, 2020

Conversation

vporton
Copy link
Contributor

@vporton vporton commented Feb 3, 2020

…more.

Description
Refers/Fixes
Testing

@danlipert
Copy link
Contributor

@vporton nice! I wanted to pin the date since the changing dates tend to break tests but looks like they aren't retaining the older versions so this works too :) thanks!

Copy link
Contributor

@danlipert danlipert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - can you remove the commented out links as well? thanks!

@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #5924 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5924      +/-   ##
==========================================
+ Coverage   29.39%   29.42%   +0.02%     
==========================================
  Files         270      270              
  Lines       23090    23090              
  Branches     3353     3353              
==========================================
+ Hits         6788     6794       +6     
+ Misses      16013    16007       -6     
  Partials      289      289
Impacted Files Coverage Δ
app/dashboard/embed.py 28.73% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc7d41e...d9a77c0. Read the comment docs.

@thelostone-mc thelostone-mc merged commit 7483fc5 into gitcoinco:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants