Hack nav #5917
Hack nav #5917
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5917 +/- ##
===========================================
- Coverage 29.35% 17.51% -11.85%
===========================================
Files 270 259 -11
Lines 23097 23179 +82
Branches 3353 3372 +19
===========================================
- Hits 6781 4059 -2722
- Misses 16021 19106 +3085
+ Partials 295 14 -281
Continue to review full report at Codecov.
|
|
the community subnav looks pretty thin/inconsitent with the others navs (which look awesome btw) https://docs.google.com/document/d/1q382lpfVdORIuol4NIiTYLaAQa6nQQyRqmdj5-AYRAg/edit |
|
hover cutoff issues https://bits.owocki.com/yAuLEg5R |
|
hmm the nav changes quite substantially as i go to the kudos or grants pages.. is this by design? |
Yes that is the normal dropdown but what do you think we can put there to justify a full width dropdown?
Good catch forgot to change kudos one
taking a look |
|
Made a slide with 3 diff messages with autoplay, about chat, tribes and leaderboard and fixed the size problem.
|
app/app/context.py
Outdated
| # cache.get_or_set('last_posts', last_posts, 100) | ||
| # posts = { | ||
| # 'last_posts': last_posts | ||
| # } |
There was a problem hiding this comment.
^ should we remove these ?
app/app/context.py
Outdated
| # } | ||
|
|
||
| # posts['json_context'] = json.dumps(posts) | ||
| print(last_posts) |
app/assets/v2/css/landing_page.css
Outdated
| .navbar.following img, | ||
| .navbar.following .nav-item, | ||
| .navbar.following i.fa-angle-right { | ||
| display: none !important; | ||
| } | ||
| } */ |
app/assets/v2/js/landing_page.js
Outdated
| $navbar.removeClass('following'); | ||
| navFollowState = false; | ||
| } | ||
| // if (!navFollowState && scrollContainer.scrollTop() > followStateHeight) { |
There was a problem hiding this comment.
👀 Should we just remove these ;)
| <img class="mw-100 logo-static" src="{% static "v2/images/top-bar/grants_symbol_dark.svg" %}" alt="Bounties" height="48"> | ||
| <b class="gc-megamenu-title">{% trans "Grants" %}</b> | ||
| </a> | ||
| <p class="px-2 m-0 mb-2 text-wrap font-smaller-2">{% trans "Recurring Funding for open source" %}</p> |
There was a problem hiding this comment.
Capitalize "open source"? what do you think? I notice the capitalization is a bit different on some of the items
| <img class="mw-100 logo-static" src="{% static "v2/images/top-bar/codefund_symbol_dark.svg" %}" alt="Bounties" height="48"> | ||
| <b class="gc-megamenu-title">{% trans "Codefund" %}</b> | ||
| </a> | ||
| <p class="px-2 m-0 mb-2 text-wrap font-smaller-2">{% trans "Ethical ads to power open source" %}</p> |
There was a problem hiding this comment.
I think we should capitalize the codefund items
| <ul class="col-md-4 col-lg-2 list-unstyled {% if '/quests' in request.path %}gc-megamenu-active{% endif %}"> | ||
| <li> | ||
| <a class="text-reset" href="{% url 'quests_index' %}"> | ||
| <img class="mw-100 logo-static" src="{% static "v2/images/top-bar/quests_symbol_dark.svg" %}" alt="Bounties" height="48"> |
There was a problem hiding this comment.
alt tag here should be for quests
| <ul class="col-md-4 col-lg-2 list-unstyled {% if '/hackathon' in request.path %}gc-megamenu-active{% endif %}"> | ||
| <li> | ||
| <a class="text-reset" href="{% url 'get_hackathons' %}"> | ||
| <img class="mw-100 logo-static" src="{% static "v2/images/top-bar/hackathons_symbol_dark.svg" %}" alt="Bounties" height="48"> |
There was a problem hiding this comment.
alt tag here should be hackathons
| <ul class="col-md-4 col-lg-2 list-unstyled {% if '/grants' in request.path %}gc-megamenu-active{% endif %}"> | ||
| <li> | ||
| <a class="text-reset" href="{% url 'grants:grants' %}"> | ||
| <img class="mw-100 logo-static" src="{% static "v2/images/top-bar/grants_symbol_dark.svg" %}" alt="Bounties" height="48"> |
| <ul class="col-md-4 col-lg-2 list-unstyled"> | ||
| <li> | ||
| <a class="text-reset" href="https://codefund.app/"> | ||
| <img class="mw-100 logo-static" src="{% static "v2/images/top-bar/codefund_symbol_dark.svg" %}" alt="Bounties" height="48"> |
| <ul class="col-md-4 col-lg-2 list-unstyled {% if '/kudos' in request.path %}gc-megamenu-active{% endif %}"> | ||
| <li> | ||
| <a class="text-reset" href="{% url 'kudos_main' %}"> | ||
| <img class="mw-100 logo-static" src="{% static "v2/images/top-bar/kudos_symbol_dark.svg" %}" alt="Bounties" height="48"> |
| <img class="mw-100 logo-static" src="{% static "v2/images/top-bar/quests_symbol_dark.svg" %}" alt="Bounties" height="48"> | ||
| <b class="gc-megamenu-title">{% trans "Quests" %}</b> | ||
| </a> | ||
| <p class="px-2 m-0 mb-2 text-wrap font-smaller-2">{% trans "Learn about web3 & earn rewards" %}</p> |
| <img class="mw-100 logo-static" src="{% static "v2/images/top-bar/kudos_symbol_dark.svg" %}" alt="Bounties" height="48"> | ||
| <b class="gc-megamenu-title">{% trans "Kudos" %}</b> | ||
| </a> | ||
| <p class="px-2 m-0 mb-2 text-wrap font-smaller-2">{% trans "Show appreciation for each other." %}</p> |
There was a problem hiding this comment.
None of the other descriptions have punctuation, so I think we should remove the . here
|
All done guys!!!! |
Description
This is a menu redesign for all the app, keeping the menu consistent in all places, more arguments on "why" on the issue ticket.
Also a few others fixes:
Refers/Fixes
fix #5485
Testing
https://share.vidyard.com/watch/gtg81fg57HXXUkDaBtqquY?