Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#hackweek tribe titles #5900

Merged
merged 2 commits into from
Feb 4, 2020
Merged

#hackweek tribe titles #5900

merged 2 commits into from
Feb 4, 2020

Conversation

danlipert
Copy link
Contributor

Description

This PR adds the ability for a tribe owner to set their tribe members' titles

Refers/Fixes

hack week

Testing

https://drive.google.com/file/d/1I6gpJPAO1Q622gq1_rN8drXsXMkHtpfY/view

@danlipert danlipert changed the title tribe titles #hackweek tribe titles Jan 29, 2020
@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #5900 into master will decrease coverage by <.01%.
The diff coverage is 18.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5900      +/-   ##
==========================================
- Coverage    29.5%   29.49%   -0.01%     
==========================================
  Files         265      265              
  Lines       22871    22887      +16     
  Branches     3320     3324       +4     
==========================================
+ Hits         6748     6751       +3     
- Misses      15845    15855      +10     
- Partials      278      281       +3
Impacted Files Coverage Δ
app/app/urls.py 90.38% <ø> (ø) ⬆️
app/dashboard/models.py 55.61% <100%> (+0.01%) ⬆️
app/dashboard/views.py 11.64% <13.33%> (+0.01%) ⬆️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7efca07...8dec859. Read the comment docs.

@owocki
Copy link
Contributor

owocki commented Jan 29, 2020

looks good. but the positioning of the blue buttons together hurts me brain

@thelostone-mc thelostone-mc merged commit a3bcc6a into master Feb 4, 2020
@thelostone-mc thelostone-mc deleted the tribe-titles branch June 27, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants