Show dropdown when user is about to tag a person using @ #5839
Conversation
KiChjang
force-pushed
the
username-tag
branch
from
124a943 to
b9bdcdb
Compare
Codecov Report
@@ Coverage Diff @@
## master #5839 +/- ##
=========================================
- Coverage 29.55% 29.45% -0.1%
=========================================
Files 266 265 -1
Lines 22653 22862 +209
Branches 3289 3320 +31
=========================================
+ Hits 6694 6734 +40
- Misses 15682 15854 +172
+ Partials 277 274 -3
Continue to review full report at Codecov.
|
KiChjang
force-pushed
the
username-tag
branch
from
476fdff to
288ba47
Compare
KiChjang
force-pushed
the
username-tag
branch
from
06f3f48 to
b083075
Compare
KiChjang
requested review from
danlipert,
octavioamu and
thelostone-mc
as code owners
|
I'm unsure if I need a new migration for this -- my guess is that I don't, because python defaults missing email preferences to a false value. I'm also not quite understanding why Travis CI is failing, perhaps it's an infrastructure issue? |
|
|
||
| <p> | ||
|
|
||
| <a href="{{psot.profile.url}}">@{{post.profile.handle}}</a> mentioned you in a post. This is what the post looks like: |
| @@ -1250,6 +1264,13 @@ def comment(request): | |||
| return HttpResponse(response_html) | |||
|
|
|||
|
|
|||
| @staff_member_required | |||
| def mention(request): | |||
There was a problem hiding this comment.
is this for testing? Is there a URL that points to this view?
There was a problem hiding this comment.
No, but I figured that this might be a function that can be called by a staff member to manually trigger the email, since other kinds of notifications also have a similar method (look above and below).
There was a problem hiding this comment.
I see - normally we hook these views into the router behind our admin endpoint like this: https://github.com/gitcoinco/web/blob/master/app/app/urls.py#L486
That way our design team can check out what the email looks like - can you go ahead and hook this view into the router? thanks!
KiChjang
force-pushed
the
username-tag
branch
from
b083075 to
7931016
Compare
|
guys.. this needs testing next time https://bits.owocki.com/bLuGWxPg |
|
antoher one https://bits.owocki.com/v1umZLXn this PR had no less than 3 errors in different places |
|
here is my fix 75f609f |
|
@owocki Sorry, I didn't quite understand the backend architecture and was hoping that my mistakes would be caught during code review. Is there any documentation I can read in order to familiarize myself with it? |
Description
Show dropdown of a list of users when a @ is detected in the textarea.
Refers/Fixes
Fixes #5823.
Testing