Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes kudos foreign keys #5828

Merged
merged 2 commits into from
Feb 5, 2020
Merged

fixes kudos foreign keys #5828

merged 2 commits into from
Feb 5, 2020

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Jan 17, 2020

Description

fixes kudos foreign keys, which were called 'kudos' but were actually kudostransfers

  • fixes the activity feed such that the kudos are actually linked correctly in the activity feed items
  • fixes the kudos details page so that you can see a newsfeed of them being funded on the kudos details
Refers/Fixes

twitter DM from a gitcoin user

Testing

tested on my local

@codecov
Copy link

codecov bot commented Jan 27, 2020

Codecov Report

Merging #5828 into stable will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           stable    #5828   +/-   ##
=======================================
  Coverage   29.55%   29.55%           
=======================================
  Files         265      265           
  Lines       22713    22713           
  Branches     3299     3299           
=======================================
  Hits         6713     6713           
  Misses      15720    15720           
  Partials      280      280

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 351661c...624d32d. Read the comment docs.

@owocki owocki force-pushed the kevin/kudos_correct branch from 796486c to 351661c Compare January 27, 2020 19:58
@owocki
Copy link
Contributor Author

owocki commented Jan 27, 2020

just fixed merge conflicts

@danlipert danlipert merged commit af89d30 into stable Feb 5, 2020
danlipert added a commit that referenced this pull request Feb 5, 2020
@thelostone-mc thelostone-mc deleted the kevin/kudos_correct branch June 27, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants