Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove web3 check for ETC bounty detail + cancel + fulfill #5826

Merged
merged 2 commits into from
Feb 5, 2020

Conversation

thelostone-mc
Copy link
Member

@thelostone-mc thelostone-mc commented Jan 17, 2020

Description

This check ensure that web3 checks don't kick in when for non ETH/ERC20 bounties
It's got a variable defined is_standard_bounties which is leveraged to check if

Bounty Detail Page

image

Bounty Fullfillment Page

Screenshot 2020-01-17 at 6 57 54 PM

Bounty Cancel Page

Screenshot 2020-01-17 at 6 59 51 PM

Refers/Fixes
Testing

@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #5826 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5826   +/-   ##
=======================================
  Coverage   29.57%   29.57%           
=======================================
  Files         266      266           
  Lines       22653    22653           
  Branches     3289     3289           
=======================================
  Hits         6700     6700           
  Misses      15676    15676           
  Partials      277      277

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5862792...19c6194. Read the comment docs.

@thelostone-mc thelostone-mc merged commit 3f385f3 into gitcoinco:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants