feat: tweak grant fund settings #5807
Conversation
- grant team members cannot fund their own grant - fund button is made hidden for grant owner + team members - added new field link_to_new_grant which is set when grant is migrated - if grant has link_to_new_grant -> fund button is replaced with button to link to new grant. - funding is blocked on old grants
|
@owocki could you check out the |
Codecov Report
@@ Coverage Diff @@
## stable #5807 +/- ##
==========================================
- Coverage 29.75% 29.54% -0.21%
==========================================
Files 260 266 +6
Lines 22012 22654 +642
Branches 3193 3290 +97
==========================================
+ Hits 6549 6694 +145
- Misses 15186 15680 +494
- Partials 277 280 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
'back to grant' looks kind of funny on https://bits.owocki.com/llu47w4g
left a few minor comments.. other than those LGTM
| ] | ||
| list_display =['pk', 'title', 'active','grant_type', 'link', 'hidden'] | ||
| list_display =['pk', 'title', 'active','grant_type', 'link', 'hidden', 'migrated_to'] | ||
| raw_id_fields = ['admin_profile'] |
There was a problem hiding this comment.
should we add to raw_id_fields? i honestly just like the raw id field explorer more than the regular FK explorer
There was a problem hiding this comment.
You mean it'd end up like this -> I didn't want this to be edited via admin cause I wanted to ensure this is done via migrate_grant.py script file
right now -> the migrated_to displayed in table and within the grant admin page is a read only mode
|
@owocki updated it |
Description
is migrated
with button to link to new grant.
Steps
Testing