Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hackathon projects to profile #5802

Merged
merged 1 commit into from
Jan 15, 2020
Merged

add hackathon projects to profile #5802

merged 1 commit into from
Jan 15, 2020

Conversation

octavioamu
Copy link
Contributor

Description

Adds hackathon tab to profiles showing the projects I created.

Refers/Fixes

fix: #5787

Testing

image

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #5802 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5802      +/-   ##
==========================================
- Coverage   29.66%   29.65%   -0.01%     
==========================================
  Files         258      258              
  Lines       22012    22015       +3     
  Branches     3201     3202       +1     
==========================================
  Hits         6529     6529              
  Misses      15206    15206              
- Partials      277      280       +3
Impacted Files Coverage Δ
app/dashboard/views.py 11.57% <0%> (-0.02%) ⬇️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05cb5e8...fe67ec7. Read the comment docs.

@@ -90,7 +90,7 @@ <h2 class="text-center">{% trans "Job Opportunities" %}</h2>
<div class="col-12 font-body mt-4">
<label class="form__label label d-block" for="linkedinUrl">{% trans "Linkedin profile" %}</label>
<div class="d-flex align-items-center">
<span>https://www.linkedin.com/in/</span><input name="linkedinUrl" id="linkedinUrl" value="{{profile.linkedin_url}}" class="form__input" type="text" placeholder="username" />
<span>https://www.linkedin.com/in/</span><input name="linkedinUrl" id="linkedinUrl" value="{% firstof profile.linkedin_url or '' %}" class="form__input" type="text" placeholder="username" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this fix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I get into the job edition from was None as linkedin so If I didn't remove None before saving then my profile get with linkedin/None

@danlipert danlipert merged commit 9e35a0d into master Jan 15, 2020
@thelostone-mc thelostone-mc deleted the profile-hackathons branch June 27, 2020 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add projects to people profiles
2 participants