Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the fetch org on login #5790

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Fix the fetch org on login #5790

merged 1 commit into from
Jan 14, 2020

Conversation

octavioamu
Copy link
Contributor

@octavioamu octavioamu commented Jan 13, 2020

Description

Fix orgs not being fetched when someone without the 'orgs' scope login. This was something we changed for "permission management" but we didn't changed back when rolled back the scopes.

Also this fix an error on login happening sometimes on localhost as how is docker setup:
"werkzeug/filesystem.py:60: BrokenFilesystemWarning: Detected a misconfigured UNIX filesystem: Will use UTF-8 as filesystem encoding instead of 'ascii'"
"UnicodeEncodeError: 'ascii' codec can't encode character '\xe1' in position 988"

Refers/Fixes
Testing

@codecov
Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #5790 into master will increase coverage by 0.24%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5790      +/-   ##
==========================================
+ Coverage   29.71%   29.96%   +0.24%     
==========================================
  Files         257      258       +1     
  Lines       21935    22474     +539     
  Branches     3189     3332     +143     
==========================================
+ Hits         6518     6734     +216     
- Misses      15140    15438     +298     
- Partials      277      302      +25
Impacted Files Coverage Δ
app/app/utils.py 22.74% <0%> (ø) ⬆️
app/kudos/views.py 14.51% <0%> (-0.55%) ⬇️
app/grants/views.py 14.18% <0%> (-0.48%) ⬇️
app/grants/clr.py 0% <0%> (ø) ⬆️
app/dashboard/views.py 11.59% <0%> (ø) ⬆️
...rketing/management/commands/no_applicants_email.py 0% <0%> (ø) ⬆️
...arketing/management/commands/export_graph_edges.py 0% <0%> (ø) ⬆️
...grants/management/commands/contribution_checker.py 0% <0%> (ø)
app/retail/emails.py 25.07% <0%> (+1.69%) ⬆️
app/grants/admin.py 48.54% <0%> (+3.18%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4f3a69...37fa26c. Read the comment docs.

@danlipert danlipert merged commit eae039b into master Jan 14, 2020
@thelostone-mc thelostone-mc deleted the fix/login-orgs-member branch June 27, 2020 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants