Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds linux and mac desktop apps; alerts users when apps not ready yet #5763

Merged
merged 4 commits into from
Jan 10, 2020

Conversation

owocki
Copy link
Contributor

@owocki owocki commented Jan 10, 2020

Description

adds linux and mac desktop apps; alerts users when apps not ready yet

Refers/Fixes

slack convo

Testing

tested locally

app/assets/v2/js/pages/chat.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #5763 into master will increase coverage by 1.3%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #5763     +/-   ##
=========================================
+ Coverage   29.87%   31.17%   +1.3%     
=========================================
  Files         257      257             
  Lines       21809    24050   +2241     
  Branches     3170     3875    +705     
=========================================
+ Hits         6515     7498    +983     
- Misses      15014    16206   +1192     
- Partials      280      346     +66
Impacted Files Coverage Δ
app/chat/views.py 29.16% <ø> (ø) ⬆️
app/chat/management/commands/sync_users_to_chat.py 0% <0%> (ø) ⬆️
app/app/context.py 64.17% <0%> (ø) ⬆️
app/dashboard/views.py 12.93% <100%> (+0.95%) ⬆️
app/chat/tasks.py 25% <100%> (ø) ⬆️
app/kudos/views.py 13.58% <0%> (-1.6%) ⬇️
app/dashboard/notifications.py 17.07% <0%> (+0.6%) ⬆️
app/dashboard/router.py 37.53% <0%> (+2.8%) ⬆️
app/dashboard/admin.py 69.64% <0%> (+5.15%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd34762...63e898e. Read the comment docs.

Copy link
Contributor

@octavioamu octavioamu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some lint problem and will be ready npm run eslint

@octavioamu
Copy link
Contributor

Approved, do you want to merge this one to master? not stable?

@owocki
Copy link
Contributor Author

owocki commented Jan 10, 2020

ill cherrypick to stable!

@owocki owocki merged commit e4f3a69 into master Jan 10, 2020
@thelostone-mc thelostone-mc deleted the kevin/chat-desktop-apps branch June 27, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants