Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ui element fixes #5759

Merged
merged 4 commits into from
Feb 4, 2020
Merged

Ui element fixes #5759

merged 4 commits into from
Feb 4, 2020

Conversation

iamonuwa
Copy link
Contributor

Description

Fix UI inconsistency on tabs.

Refers/Fixes

Fixes #5718

Testing

Checkout profile page tabs and quests tabs to view it.

@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

Merging #5759 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5759      +/-   ##
==========================================
+ Coverage   29.65%   29.68%   +0.02%     
==========================================
  Files         258      258              
  Lines       22015    22015              
  Branches     3202     3202              
==========================================
+ Hits         6529     6535       +6     
+ Misses      15209    15203       -6     
  Partials      277      277
Impacted Files Coverage Δ
app/dashboard/embed.py 31.6% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e35a0d...1cb3bc7. Read the comment docs.

Copy link
Member

@thelostone-mc thelostone-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments

app/assets/v2/js/pages/profile.js Outdated Show resolved Hide resolved
app/assets/v2/js/pages/profile.js Outdated Show resolved Hide resolved
@iamonuwa
Copy link
Contributor Author

Left a few comments

Issues has been resolved

@danlipert
Copy link
Contributor

@iamonuwa video of the changes please 👍

@iamonuwa
Copy link
Contributor Author

@iamonuwa
Copy link
Contributor Author

Any more issues here guys?

@iamonuwa iamonuwa requested a review from androolloyd January 24, 2020 15:20
@thelostone-mc thelostone-mc merged commit 34f245c into gitcoinco:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify Inconsistent UI elements - Tabs
3 participants