Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/deploy fixes #5757

Merged
merged 5 commits into from
Jan 9, 2020
Merged

Fix/deploy fixes #5757

merged 5 commits into from
Jan 9, 2020

Conversation

octavioamu
Copy link
Contributor

Description

remove discord links
links new chat to main nav
fix links to chat chat/landing
fix hackathon list link

Refers/Fixes
Testing

<img src="{% static "v2/images/top-bar/hackathons-logo.svg" %}" height="23" width="125" alt="" class="d-md-block d-none" style="margin-top: 0px; margin-left: -10px;">
<img src="{% static "v2/images/top-bar/hackathons-symbol.svg" %}" height="22" alt="" class="d-md-none" style="height: 55px; width: 55px; margin-top: -7px; margin-left: -15px;">
</a>
<a class="{% if request.path == '/' %}selected{% endif %}" href="{% url 'funder_bounties' %}">
<a class="{% if request.path == '/' %}selected{% endif %}" href="">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmmm the main landing page isnt the bounties landing page.. its the main gitcoin site lander. did you mean to do this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch that was a mistake didn't mean to change nothing in that line

@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #5757 into stable will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           stable    #5757   +/-   ##
=======================================
  Coverage   29.87%   29.87%           
=======================================
  Files         257      257           
  Lines       21809    21809           
  Branches     3170     3170           
=======================================
  Hits         6515     6515           
  Misses      15017    15017           
  Partials      277      277
Impacted Files Coverage Δ
app/app/urls.py 90.19% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd34762...361d251. Read the comment docs.

@octavioamu octavioamu merged commit 72b6cfa into stable Jan 9, 2020
@thelostone-mc thelostone-mc deleted the fix/deploy-fixes branch June 27, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants