Town Square MVP #5744

owocki · 2020-01-08T23:17:13Z

Description

This is the MVP of Town square. I will be demoing on tomorrows sprint meeting. The idea is to be the central nervous system of Gitcoin. A place to view social updates + find out whats new on the network

My hope is that this functionality MASSIVELY increases DAUs on Gitcoin

Includes

Newsfeed
Commenting
Liking
Flags
Comment Emails
Daily Actions

Refers/Fixes

https://app.mural.co/t/consensys3989/m/consensys3989/1576552443637/93b352eccd110e4827ae96f3533fa3de3a5b5571

Testing

Tested a butt ton locally

Release Plan

I plan to release this incrementally to production behind a feature flag. Since its a very social feature, iterative user feedback in production will be important (theres real data in production, so the social experience is more meaningful!).

My Todo list

v0
X likes
X comments displaying + deletion
X hook up activity/tabs

v0.1
x Flag feature 

x view action (web)
X email notifications / send me daily offers email pref on dashboard 
X new bounties => daily offer email

v0.2
x copy-able link to a post or status update on gitcoin
x Comment emails 
x you can enable town square via special cb link

- create action
- town square tabs should have hourly rates of action on them
- Tabs: mentorship, jobs, etc that match status updates

v0.3
- login first modals
- Product updates on right side? 
- Featured users in feed
- Link to chat on landing page. With number online 
- posts should link usernames or search hashtags
- minimize / expand feed button
- feed shows when new items come up 
- auto delete posts with more than one flag

# actions ideas
- anyone can click 
- free kudos
- work on a 15 minute bounty
- use mythx + give technical feedback on it


# Launch notes/checklist

launch with tweet

What to say on Twitter; Killer feature of gitcoin is its community. Unlike other web3 social networks just launching., we’ve already bootstrapped our social graph!
shilly wonka branding

CTA: Got announcement? Post here.  Want to hire? post here?

gs

codecov · 2020-01-08T23:42:35Z

Codecov Report

❗ No coverage uploaded for pull request base (master@748d396). Click here to learn what that means.
The diff coverage is 14.92%.

@@           Coverage Diff            @@
##             master   #5744   +/-   ##
========================================
  Coverage          ?   29.2%           
========================================
  Files             ?     264           
  Lines             ?   23543           
  Branches          ?    3631           
========================================
  Hits              ?    6875           
  Misses            ?   16344           
  Partials          ?     324

Impacted Files	Coverage Δ
app/app/urls.py	`90.38% <ø> (ø)`
app/grants/clr.py	`0% <0%> (ø)`
...arketing/management/commands/export_graph_edges.py	`0% <0%> (ø)`
app/retail/emails.py	`23.32% <0%> (ø)`
...grants/management/commands/contribution_checker.py	`0% <0%> (ø)`
app/marketing/mails.py	`13.42% <0%> (ø)`
app/grants/views.py	`14.41% <0%> (ø)`
app/retail/views.py	`26.9% <0%> (ø)`
app/kudos/views.py	`15.02% <0%> (ø)`
app/dashboard/admin.py	`64.62% <100%> (ø)`
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 748d396...eec30f9. Read the comment docs.

owocki · 2020-01-08T23:46:02Z

app/assets/v2/js/base.js

@@ -230,18 +230,19 @@ const alertMessage = function(msg) {
  return html;
 };

-const _alert = function(msg, _class) {
+const _alert = function(msg, _class, remove_after_ms) {


this is quite a nice little feature... removing the msg after some time... clears notifications so users dont have to!

owocki · 2020-01-08T23:49:48Z

app/townsquare/views.py

+
+
+@ratelimit(key='ip', rate='10/m', method=ratelimit.UNSAFE, block=True)
+@csrf_exempt


havent figured out how to feed enough csrf tokens to the frontend to make multi comment experience work well. punting for now.

So I spent some time looking into this and I believe you can use the same CSRF token multiple times - it only gets invalidated on user login. https://stackoverflow.com/questions/25507514/does-django-csrf-token-must-be-unique-on-every-request

fixing this now

octavioamu · 2020-01-09T21:58:53Z

app/assets/v2/js/shared.js

@@ -1498,6 +1498,16 @@ $(document).ready(function() {
  });
 });

+const copyToClipboard = str => {


don't know if exactly what you need but there is https://github.com/gitcoinco/web/blob/master/app/assets/v2/js/clipboard.js

hmmm yeah this function is somehwat different (creates a diff message in a diff way, my copyToClipBoard() file, which is more generlizaable...

octavioamu · 2020-01-09T22:12:50Z

made a quick view looking nice I need to go deeper.
For other side I will say Owocki come to the Vue side, lot of interactions would be so easy to do with vue here.

owocki · 2020-01-09T23:21:07Z

good call; i wish i had thought of the vue stuff before i broke ground on this!

danlipert · 2020-01-13T13:04:37Z

app/dashboard/models.py

+    @property
+    def text(self):
+        from django.template.loader import render_to_string
+        from bs4 import BeautifulSoup


We should move these imports to module scope

danlipert

Fat PR! Looks good though - I think we can deploy Wednesday if you can turn around some of these comments quick

app/dashboard/models.py

danlipert · 2020-01-13T13:10:49Z

app/marketing/mails.py

+    for to_email in to_emails:
+        cur_language = translation.get_language()
+        try:
+            setup_lang(to_email)


Can move the setup_lang and cur_language calls out of the loop for a tiny bit of performance

cur_language and setup_lang are each relative to each to_email so we cant do that..

my bad on the setup_lang part - for the get_language part my understanding is that we are storing the current language (english) - then translating the email via the setup_lang function which changes the current language, then going back to english with the finally: section. So its probably good to move out of the loop, right?

app/marketing/mails.py

danlipert · 2020-01-13T13:12:59Z

app/marketing/mails.py

@@ -747,7 +787,24 @@ def new_bounty_daily(bounties, old_bounties, to_emails=None):
    plural = "s" if len(bounties) != 1 else ""
    worth = round(sum([bounty.value_in_usdt for bounty in bounties if bounty.value_in_usdt]), 2)
    worth = f" worth ${worth}" if worth else ""
-    subject = _(f"⚡️  {len(bounties)} New Open Funded Issue{plural}{worth} matching your profile")
+    offers = f""
+    if to_emails and len(to_emails):


What is the len check here covering?

danlipert · 2020-01-13T13:13:46Z

app/marketing/mails.py

-    subject = _(f"⚡️  {len(bounties)} New Open Funded Issue{plural}{worth} matching your profile")
+    offers = f""
+    if to_emails and len(to_emails):
+        from townsquare.utils import is_email_townsquare_enabled, is_there_an_action_available


is this to avoid a circular import? Performance isn't a huge deal here since its outside of a request/response cycle but always good to check

nah; just laziness.. removing

app/townsquare/models.py

app/townsquare/tasks.py

danlipert · 2020-01-13T13:38:13Z

app/townsquare/views.py

+
+
+@ratelimit(key='ip', rate='10/m', method=ratelimit.UNSAFE, block=True)
+@csrf_exempt


So I spent some time looking into this and I believe you can use the same CSRF token multiple times - it only gets invalidated on user login. https://stackoverflow.com/questions/25507514/does-django-csrf-token-must-be-unique-on-every-request

app/townsquare/views.py

danlipert · 2020-01-13T13:45:46Z

app/townsquare/views.py

+            return redirect('/login/github?next=' + request.get_full_path())
+        if request.user.profile.offeractions.filter(what='click', offer=offer) and not is_debugging_offers:
+            raise Exception('already visited this offer')
+        OfferAction.objects.create(profile=request.user.profile, offer=offer, what='click')


Lots of code in these methods we could DRY up

id be open to discussions about how to do that... if we were gonna get fancy we could use an inherited class or view or something..

I think just a non-view helper function is probably fine, something like offer = get_offer_and_create_offer_action(offer_id, what='click')

owocki · 2020-01-13T21:25:22Z

@danlipert i turned around all the code review here => 3288bbb

lets aim for weds deploy pls!

owocki · 2020-01-14T17:17:24Z

latest code review turnaround => abd3563

octavioamu · 2020-01-15T12:54:36Z

app/app/urls.py

@@ -361,6 +364,16 @@
    re_path(r'^results/?(?P<keyword>.*)/?', retail.views.results, name='results_by_keyword'),
    re_path(r'^results/?', retail.views.results, name='results'),
    re_path(r'^activity/?', retail.views.activity, name='activity'),
+    re_path(r'^townsquare/?', townsquare.views.index, name='townsquare'),
+    re_path(r'^$', townsquare.views.index, name='inex'),


typo? "inex"

octavioamu · 2020-01-15T15:18:43Z

@owocki There are some stuff I can review but instead since a design for this is coming I can fix css and styles then.

owocki added 20 commits December 31, 2019 08:06

town square initial commit

05196a6

feed is working

17131eb

adds commenting/liking functionality

e6d96b1

make fix

8100c41

resets migrations + also starts to lay the groundwork for offers

0763287

show offers on townsquare

a4141f8

fix for activity stream

89a6f95

offers

334033f

timers

37ab937

UI for town square/ actions

957aa1a

adds flag feature + also limits text box input

5883c12

a few small fixes

f3f721b

make fix

1272622

responsiveness

69d9f7f

town square emails now hooked up"

8535a5c

gs

action views

bb702cc

preview offer button

c684e3f

activity feed links

d015367

comment emails

81c6891

make fix

969e374

owocki requested review from danlipert, octavioamu and thelostone-mc as code owners January 8, 2020 23:17

merge conflicts

8f4aadf

owocki commented Jan 8, 2020

View reviewed changes

owocki added 2 commits January 8, 2020 21:30

live updates on town square

e13b4e1

make fix

247e83f

make fix

12764a4

owocki mentioned this pull request Jan 9, 2020

As Gitcoin, I want to enable BUIDLers in the community to effectively drive towards #onemilliondevs with *Gitcoin Town Square*, so we can realize the #onemilliondevs vision. #5543

Closed

owocki added 3 commits January 9, 2020 13:41

Merge branch 'stable' into kevin/townsquare

cb44ead

make fix

5fb1259

html cleanup

e1e3490

octavioamu reviewed Jan 9, 2020

View reviewed changes

submit actions via the web

dfe444d

danlipert reviewed Jan 13, 2020

View reviewed changes

danlipert suggested changes Jan 13, 2020

View reviewed changes

code

3288bbb

owocki added 7 commits January 13, 2020 14:27

Merge branch 'master' into kevin/townsquare

748d396

Merge branch 'master' into kevin/townsquare

52b6426

activity feed on grants profile

a54f11e

ability to write on each others walls, flag profiles

8a5f911

activity tabs on kudos

25141ea

staff can INSTANTly remove an item by flagging it

ded9e88

DL code review

abd3563

danlipert approved these changes Jan 15, 2020

View reviewed changes

octavioamu reviewed Jan 15, 2020

View reviewed changes

owocki added 2 commits January 15, 2020 07:21

wall posts

39564e0

typo

eec30f9

octavioamu approved these changes Jan 15, 2020

View reviewed changes

octavioamu merged commit 7953429 into master Jan 15, 2020

thelostone-mc deleted the kevin/townsquare branch June 27, 2020 00:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Town Square MVP #5744

Town Square MVP #5744

owocki commented Jan 8, 2020

codecov bot commented Jan 8, 2020 •

edited

Loading

owocki Jan 8, 2020

owocki Jan 8, 2020

danlipert Jan 13, 2020

owocki Jan 13, 2020

octavioamu Jan 9, 2020

owocki Jan 9, 2020

octavioamu commented Jan 9, 2020

owocki commented Jan 9, 2020

danlipert Jan 13, 2020

owocki Jan 13, 2020

danlipert left a comment

danlipert Jan 13, 2020

owocki Jan 13, 2020

danlipert Jan 14, 2020

owocki Jan 14, 2020

danlipert Jan 13, 2020

owocki Jan 13, 2020

danlipert Jan 13, 2020

owocki Jan 13, 2020

danlipert Jan 13, 2020

danlipert Jan 13, 2020

owocki Jan 13, 2020

danlipert Jan 14, 2020

owocki Jan 14, 2020

owocki commented Jan 13, 2020

owocki commented Jan 14, 2020

octavioamu Jan 15, 2020

owocki Jan 15, 2020

octavioamu commented Jan 15, 2020



		@ratelimit(key='ip', rate='10/m', method=ratelimit.UNSAFE, block=True)
		@csrf_exempt

Town Square MVP #5744

Town Square MVP #5744

Conversation

owocki commented Jan 8, 2020

Description

Refers/Fixes

Testing

Release Plan

codecov bot commented Jan 8, 2020 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

octavioamu commented Jan 9, 2020

owocki commented Jan 9, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danlipert left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

owocki commented Jan 13, 2020

owocki commented Jan 14, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

octavioamu commented Jan 15, 2020

codecov bot commented Jan 8, 2020 •

edited

Loading